Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3461

iframe-viewer uses a string in hideUntil instead of a boolean

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.9.0
    • 3.9.1
    • Others
    • Moodle App 3.9.1

    Description

      The component core-loading expects to receive a boolean in the hideUntil input, but the iframe-viewer page is passing a string (the URL). In the ngOnInit function we don't check the type so it works, but if the url is loaded after the ngOnInit function has run then the CSS classes aren't applied as they should.

      We should evaluate if we want to make the input more generic (not just booleans) or we want to fix all the places that are not sending a boolean right now.

      Attachments

        Activity

          People

            dpalou Dani Palou
            dpalou Dani Palou
            Pau Ferrer Pau Ferrer
            Juan Leyva Juan Leyva
            Isabel Renedo Rouco Isabel Renedo Rouco
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              3/Jul/20