Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3471

Find a way to have webview plugin only in iOS

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for integration review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9.0
    • Fix Version/s: None
    • Labels:
    • Testing Instructions:
      Hide

      This issue should be tested both in Android and iOS.

      1. Install the app and login in master site. Check that embedded images are loaded fine.
      2. Go to "MM Dev Testing Course > SCORM > SCORM with links _top, ...".
      3. Open the SCORM and click the link "Link to Google!". Check that Google is opened in browser.
      Show
      This issue should be tested both in Android and iOS. Install the app and login in master site. Check that embedded images are loaded fine. Go to "MM Dev Testing Course > SCORM > SCORM with links _top, ...". Open the SCORM and click the link "Link to Google!". Check that Google is opened in browser.
    • Affected Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
    • Sprint:
      Moodle App 3.9.3

      Description

      Due to some technical limitations we had to remove the plugin cordova-plugin-ionic-webview from Android. The problem is that cordova doesn't let you specify that a plugin should only be installed in one platform, so it automatically installs it in both.

      It's really annoying to have to install/uninstall the plugin everytime you switch platform, we should find a solution. Some possible options:

      1. Implement a hook that automatically adds or removes the plugin. The problem is that the hook will modify package.json.
      2. Create a fork of the plugin and remove the android platform from there, that way the plugin will only be installed in ios. The problem is that we'll have to keep the plugin up-to-date.
      3. Use plugman to install the plugin only in iOS. The problem is that plugin doesn't register this anywhere, there is no record that the plugin is installed. Also, the command would have to be used everytime the platform is removed and re-added.
      4. Create our own custom CLI and use it on top of ionic/cordova CLI.

        Attachments

          Activity

            People

            Assignee:
            dpalou Dani Palou
            Reporter:
            dpalou Dani Palou
            Peer reviewer:
            Noel De Martin
            Participants:
            Component watchers:
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated: