Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3320 Update to Ionic 5
  3. MOBILE-3691

Prevent iframe navigation from taking over the app

    XMLWordPrintable

Details

    • Sub-task
    • Resolution: Fixed
    • Minor
    • 3.9.5
    • 3.9.4
    • Ionic
    • Hide

      Test recaptcha

      This part should be tested in 1 Android and 1 iOS device.

      1. In the app, go to add a site and enter the 34 site URL.
      2. Click to create an account.
      3. Put a valid age and continue.
      4. Fill all the form fields.
      5. Click to answer the security question. Check that you can answer it fine.
      6. Click to create the account. Check that no error is displayed.

      Test iframe

      I tried adding an embedded custom menu item pointing to a github gist, but it seems they have X-Frame-Options set to deny. So IMO it's better if this part is tested by a developer.

      This part only needs to be tested in Android.

      1. In a local site, add the HTML file attached to this issue.
      2. Edit the last link to point to a course in your local site.
      3. In browser, login as admin and go to Site administration > Mobile app > Mobile features.
      4. In Custom menu items, add: 

      Iframe|http://192.168.0.17/test_files/test_iframe_access.html|embedded|en

      But replacing the URL with the one of your local file.

      1. In the app, login in that site.
      2. Open the More menu and open that menu item.
      3. Click any of the Google links. Check that the Google page is opened in browser.
      4. Click the course link. Check that it's opened in the app.
      Show
      Test recaptcha This part should be tested in 1 Android and 1 iOS device. In the app, go to add a site and enter the 34 site URL. Click to create an account. Put a valid age and continue. Fill all the form fields. Click to answer the security question. Check that you can answer it fine. Click to create the account. Check that no error is displayed. Test iframe I tried adding an embedded custom menu item pointing to a github gist, but it seems they have X-Frame-Options set to deny. So IMO it's better if this part is tested by a developer. This part only needs to be tested in Android. In a local site, add the HTML file attached to this issue. Edit the last link to point to a course in your local site. In browser, login as admin and go to Site administration > Mobile app > Mobile features. In Custom menu items, add:  Iframe|http://192.168.0.17/test_files/test_iframe_access.html|embedded|en But replacing the URL with the one of your local file. In the app, login in that site. Open the More menu and open that menu item. Click any of the Google links. Check that the Google page is opened in browser. Click the course link. Check that it's opened in the app.
    • MOODLE_39_STABLE
    • MOODLE_39_STABLE
    • Moodle App 3.9.5

    Description

      This is a problem we solved by overriding window.open and other methods in iframes, however given the changes done in MOBILE-3689 this is not working anymore.

      Attachments

        Issue Links

          Activity

            People

              dpalou Dani Palou
              noeldemartin Noel De Martin
              Noel De Martin Noel De Martin
              Noel De Martin Noel De Martin
              Noel De Martin Noel De Martin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.