Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3763

H5P embedded directly (using embed code) have height=0 in the app

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for testing
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9.5
    • Fix Version/s: None
    • Component/s: H5P
    • Labels:
    • Testing Instructions:
      Hide

      You will need to test this issue in 2 devices at the same time. It doesn't matter if they're Android or iOS.

      Setup

      1. In web as admin, create a new course. This bug doesn't happen in certain conditions so it's better to create a new course.
      2. Enrol a student in the course.
      3. In this course, create an H5P activity. Make sure to enable "Embed button" in "H5P options".
      4. Open this H5P and wait for it to load.
      5. Click the "Embed" button at the bottom and copy the HTML code.
      6. Create a label in the same course. In the label text, click the button to display the HTML code and copy the code you copied in the previous step.
      7. Before saving, check if the HTML iframe has something like "height="388"". If it does, remove it (you can leave style="height: 0px"). This is to ensure that the bug described in this issue happens.
      8. Save the label. Check that the H5P package is displayed correctly.

      Test

      1. In the app, login as the same student in both devices.
      2. In device 1, open the course and go to the label. Check that the H5P package is displayed correctly.
      3. In device 2, and before 6 minutes pass since the last step, open the course and go to the label. Check that it displays the login form because the auto-login failed (you already used auto-login in device 1).
      4. Enter the username and password in the iframe and send them. Check that now the H5P package is displayed correctly.
      Show
      You will need to test this issue in 2 devices at the same time. It doesn't matter if they're Android or iOS. Setup In web as admin, create a new course. This bug doesn't happen in certain conditions so it's better to create a new course. Enrol a student in the course. In this course, create an H5P activity. Make sure to enable "Embed button" in "H5P options". Open this H5P and wait for it to load. Click the "Embed" button at the bottom and copy the HTML code. Create a label in the same course. In the label text, click the button to display the HTML code and copy the code you copied in the previous step. Before saving, check if the HTML iframe has something like "height="388"". If it does, remove it (you can leave style="height: 0px"). This is to ensure that the bug described in this issue happens. Save the label. Check that the H5P package is displayed correctly. Test In the app, login as the same student in both devices. In device 1, open the course and go to the label. Check that the H5P package is displayed correctly. In device 2, and before 6 minutes pass since the last step, open the course and go to the label. Check that it displays the login form because the auto-login failed (you already used auto-login in device 1). Enter the username and password in the iframe and send them. Check that now the H5P package is displayed correctly.
    • Affected Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
    • Sprint:
      Moodle App 4.0

      Description

      How to reproduce:

      1. In a course, create an H5P activity. Select the "Embed button" checkbox in the "H5P options" section before saving the H5P activity.
      2. Click over the "<> Embed" icon that appears below the H5P activity and copy the H5P embed code.
      3. Now create a Label. In the "Label text" field, show the advanced Atto buttons, click over the "</> HTML" button and paste the embedded code copied previously.
      4. In the app, view the label. Check that the iframe isn't seen.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dpalou Dani Palou
              Reporter:
              dpalou Dani Palou
              Peer reviewer:
              Pau Ferrer Pau Ferrer
              Integrator:
              Pau Ferrer Pau Ferrer
              Tester:
              Isabel Renedo Rouco Isabel Renedo Rouco
              Participants:
              Component watchers:
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: