Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3775

PTR on a page doesn't update the page contents

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for testing
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9.5
    • Fix Version/s: None
    • Component/s: Page add-on
    • Labels:
    • Testing Instructions:
      Hide

      This issue only needs to be tested in 1 device.

      1. In web as teacher, create a page or book with some content.
      2. In the app as student, open that page/book.
      3. In web as teacher, edit the page or book contents.
      4. In the app, perform a PTR. Check that the content is updated.
      Show
      This issue only needs to be tested in 1 device. In web as teacher, create a page or book with some content. In the app as student, open that page/book. In web as teacher, edit the page or book contents. In the app, perform a PTR. Check that the content is updated.
    • Affected Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
    • Sprint:
      Moodle App 4.0

      Description

      How to reproduce:

      1. Open a page in the app.
      2. In web as teacher, edit the page contents.
      3. In the app, perform a PTR. Check that the page contents aren't updated.

      We aren't checking if the module has updates at the beginning of downloadResourceIfNeeded, so the app detects that the page hasn't changed and it doesn't download the file again. However, fixing this isn't trivial because:

      • We also need to invalidate the check updates WS call.
      • Currently getModuleStatus gets the updates of the whole course, and I'm not sure if we want that. We could probably use getModuleUpdates, but that doesn't change the status of the package.
      • When the refresh is done we call fillContextMenu that calls getModuleStatus again. It should use cached data, but still we're calling a function when it probably isn't needed.

        Attachments

          Activity

            People

            Assignee:
            dpalou Dani Palou
            Reporter:
            dpalou Dani Palou
            Peer reviewer:
            Pau Ferrer Pau Ferrer
            Integrator:
            Pau Ferrer Pau Ferrer
            Tester:
            Isabel Renedo Rouco Isabel Renedo Rouco
            Participants:
            Component watchers:
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated: