Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3775

PTR on a page doesn't update the page contents

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.9.5
    • 4.0.0
    • Page add-on
    • Hide

      This issue only needs to be tested in 1 device.

      1. In web as teacher, create a page or book with some content.
      2. In the app as student, open that page/book.
      3. In web as teacher, edit the page or book contents.
      4. In the app, perform a PTR. Check that the content is updated.
      Show
      This issue only needs to be tested in 1 device. In web as teacher, create a page or book with some content. In the app as student, open that page/book. In web as teacher, edit the page or book contents. In the app, perform a PTR. Check that the content is updated.
    • MOODLE_39_STABLE
    • MOODLE_400_STABLE
    • Moodle App 4.0

    Description

      How to reproduce:

      1. Open a page in the app.
      2. In web as teacher, edit the page contents.
      3. In the app, perform a PTR. Check that the page contents aren't updated.

      We aren't checking if the module has updates at the beginning of downloadResourceIfNeeded, so the app detects that the page hasn't changed and it doesn't download the file again. However, fixing this isn't trivial because:

      • We also need to invalidate the check updates WS call.
      • Currently getModuleStatus gets the updates of the whole course, and I'm not sure if we want that. We could probably use getModuleUpdates, but that doesn't change the status of the package.
      • When the refresh is done we call fillContextMenu that calls getModuleStatus again. It should use cached data, but still we're calling a function when it probably isn't needed.

      Attachments

        1. screenshot-1.png
          screenshot-1.png
          127 kB
        2. screenshot-2.png
          screenshot-2.png
          129 kB
        3. screenshot-3.png
          screenshot-3.png
          67 kB
        4. screenshot-4.png
          screenshot-4.png
          70 kB

        Activity

          People

            dpalou Dani Palou
            dpalou Dani Palou
            Pau Ferrer Pau Ferrer
            Pau Ferrer Pau Ferrer
            Juan Leyva Juan Leyva
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              22/Apr/22