Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3797

User profiles can cause infinite requests with custom course themes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9.4
    • Fix Version/s: 3.9.5
    • Component/s: Users
    • Labels:
    • Testing Instructions:
      Hide

      In a site with a course using a different theme than the site default, with a different default avatar:

      1. Log in with a user who hasn't uploaded an avatar (is using the default).
      2. Go to the course with the different theme.
      3. Open the list of participants, and click on the current user.
      4. If this fix works properly, only a couple of requests should be triggered. Before this fix, this would cause an infinite request loop.
      Show
      In a site with a course using a different theme than the site default, with a different default avatar: Log in with a user who hasn't uploaded an avatar (is using the default). Go to the course with the different theme. Open the list of participants, and click on the current user. If this fix works properly, only a couple of requests should be triggered. Before this fix, this would cause an infinite request loop.
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
    • Sprint:
      Moodle App 3.9.5

      Description

      The current implementation of user profiles compare the avatar url from site info with the url obtained from the user profile in a course to see if they should be refreshed. This can cause an infinite requests loop when the course is using a different theme than the site, because the urls of the default avatar can differ, for example:

      https://mymoodlesite.com/theme/image.php/boost/defaultavatar.jpg
      https://mymoodlesite.com/theme/image.php/customtheme/defaultavatar.jpg
      

        Attachments

          Activity

            People

            Assignee:
            noeldemartin Noel De Martin
            Reporter:
            noeldemartin Noel De Martin
            Peer reviewer:
            Dani Palou Dani Palou
            Integrator:
            Dani Palou Dani Palou
            Tester:
            Juan Leyva Juan Leyva
            Participants:
            Component watchers:
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              27/Aug/21