Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3982

Follow-up with Collapsible header issues

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.0.0
    • 4.0.0
    • Others
    • Hide

      Collapsible headers should work without any quirks or glitches. In particular, look out for the following scenarios:

      • Course home: header should collapse/expand on scroll.
      • Long activity: header should collapse/expand on scroll.
      • Short activity (an activity with scroll, but not enough to collapse header completely): header should not collapse at all (shouldn't behave like a collapsible header).
      • Activity without scroll: header should not collapse at all (shouldn't behave like a collapsible header).
      • Changing tabs in the course home should keep header working; and changing tabs will reset the header to be fully expanded.
      • Calendar events (most of them are too short, but if you find one that is long enough it should behave like activities).
      • Going back and forth between pages with collapsible headers shouldn't cause any visual glitches.
      • Try these in both mobile and tablet layouts.
      Show
      Collapsible headers should work without any quirks or glitches. In particular, look out for the following scenarios: Course home: header should collapse/expand on scroll. Long activity: header should collapse/expand on scroll. Short activity (an activity with scroll, but not enough to collapse header completely): header should not collapse at all (shouldn't behave like a collapsible header). Activity without scroll: header should not collapse at all (shouldn't behave like a collapsible header). Changing tabs in the course home should keep header working; and changing tabs will reset the header to be fully expanded. Calendar events (most of them are too short, but if you find one that is long enough it should behave like activities). Going back and forth between pages with collapsible headers shouldn't cause any visual glitches. Try these in both mobile and tablet layouts.
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • Moodle App 4.0

    Description

      There's a bunch of improvements to fix on the collapsible header:

      • When the scroll has just a few pixels to move it can happen that resize done by the code triggers an scroll event and enters into an infinite loop (see MOBILE-3099 attached gif). This can be solved:
        1. Detecting a loop and stopping.
        2. Using Throttle functions.
        3. Disabling the collapse to avoid that happen if we detect it can happen.
      • Sometimes it happens that when moving from one activity to another, the large header is broken (see SCORM module screenshot and COLES survey below).

      Attachments

        1. animationglittch.gif
          animationglittch.gif
          3.67 MB
        2. screenshot-3.png
          screenshot-3.png
          83 kB
        3. scrolling-issue.gif
          scrolling-issue.gif
          1.54 MB
        4. screenshot-4.png
          screenshot-4.png
          19 kB

        Issue Links

          Activity

            People

              noeldemartin Noel De Martin
              pferre22 Pau Ferrer
              Pau Ferrer Pau Ferrer
              Juan Leyva Juan Leyva
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                22/Apr/22