Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-4015

Support fallbacks for javascript click actions on the app via data-app-url

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.9.5
    • 4.0.0
    • Others
    • Hide

      This issue should be tested in 1 iOS and 1 Android device.

      1. In the app, login in master site (student).
      2. Go to MM Dev Testing course > General.
      3. Click the button "Open course in browser", it's in the section description. 
      4. Check that the course is opened in browser. Don't go back to the app yet.
      5. In a browser (other device/desktop) as admin/teacher, edit the General section description and change some text (e.g. you can add a new word, or punctuation signs, something that lets you know the text has changed).
      6. In the device, go back to the app. Check that the course is automatically refreshed and now you see the new text in the description.
      7. Now click the button "Open course in browser, no refresh, custom confirm". Check that you see a confirm modal with a "custom confirm message".
      8. Click OK. Check that the course is opened in browser.
      9. Go back to the app. Check that now the course isn't refreshed (you don't see the loading).
      10. Now click the button "Open course in InAppBrowser, custom confirm". Check that you see a confirm modal saying "Are you sure?".
      11. Click OK. Check that the course is opened in InAppBrowser. Don't close it yet.
      12. In a browser (other device/desktop) as admin/teacher, edit the General section description and change some text.
      13. In the device, close the InAppBrowser. Check that the course is automatically refreshed and now you see the new text in the description.
      Show
      This issue should be tested in 1 iOS and 1 Android device. In the app, login in master site (student). Go to MM Dev Testing course > General. Click the button "Open course in browser", it's in the section description.  Check that the course is opened in browser. Don't go back to the app yet. In a browser (other device/desktop) as admin/teacher, edit the General section description and change some text (e.g. you can add a new word, or punctuation signs, something that lets you know the text has changed). In the device, go back to the app. Check that the course is automatically refreshed and now you see the new text in the description. Now click the button "Open course in browser, no refresh, custom confirm". Check that you see a confirm modal with a "custom confirm message". Click OK. Check that the course is opened in browser. Go back to the app. Check that now the course isn't refreshed (you don't see the loading). Now click the button "Open course in InAppBrowser, custom confirm". Check that you see a confirm modal saying "Are you sure?". Click OK. Check that the course is opened in InAppBrowser. Don't close it yet. In a browser (other device/desktop) as admin/teacher, edit the General section description and change some text. In the device, close the InAppBrowser. Check that the course is automatically refreshed and now you see the new text in the description.
    • MOODLE_39_STABLE
    • MOODLE_400_STABLE
    • Moodle App 4.0

    Description

      There are some plugins that inject buttons/links that interact with Moodle via javascript, for example, availability plugins.

      To offer a fallback for the Moodle app we were thinking to support a new data attribute so the button will do something if one user of the app interacts with it.

      We already have a data-open-in attribute that could also be used in combination with the previous (so the developer can choose whether to open the link, browser or inapp browser)

      Attachments

        1. Screenshot 2022-04-12 at 16.41.56.png
          581 kB
          Isabel Renedo Rouco
        2. Screenshot 2022-04-12 at 17.41.20.png
          516 kB
          Isabel Renedo Rouco

        Activity

          People

            dpalou Dani Palou
            jleyva Juan Leyva
            Noel De Martin Noel De Martin
            Isabel Renedo Rouco Isabel Renedo Rouco
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              22/Apr/22