Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-4030

Improve CanLeave guard to show unexpected errors

XMLWordPrintable

    • MOODLE_402_STABLE

      In the current implementation, the can-leave guard is ignoring all errors and assuming that the navigation was cancelled. This may arise from the fact that the CoreDomUtils.showConfirm() method, which is used in most implementations, throws an error instead of returning false. This could cause some problems if an error happens after showing users' the confirmation dialog, because they may accept leaving the screen but some other error cancels the navigation and they stay on the page.

      When looking at this, we'll also want to look at other uses of the CanLeave interface (for example, in the CoreNavigator class).

            Unassigned Unassigned
            noeldemartin Noel De Martin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.