Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-4303

Handle Vimeo videos in URL resource

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Minor
    • 4.2.0
    • 4.2.0
    • URL add-on
    • Hide

      This issue should be tested by a developer because some tests requires inspecting the DOM.

      This issue only needs to be tested in 1 device.

      Test Vimeo in a 3.7+ site

      1. In the app, login in our master site.
      2. Open "MM Dev Testing Course > Resource: URL > Embedded URL to Vimeo video". Check that the video is rendered.
      3. Inspect the iframe. Check that its src is master.mm.moodledemo.net/media/player/vimeo/wsplayer.php...

      Test Vimeo in a 3.5 site

      1. In the app, login in our 3.5 site.
      2. Open "Curso > Topic 1 > Embedded vimeo video". Check that the video is rendered.
      3. Inspect the iframe. Check that its src is player.vimeo.com.

      Test auto-login

      1. In the app, login in our master site.
      2. Open "MM Dev Testing Course > Resource: URL > Embedded URL to same site and NOT handled by the app (to test auto-login)". Check that the content is rendered without having to login.
        1. Notice 1: if you're using a student or teacher account you will see an error saying that you don't have permissions.
        2. Notice 2: This already worked before, but the code was refactored a bit.
      Show
      This issue should be tested by a developer because some tests requires inspecting the DOM. This issue only needs to be tested in 1 device. Test Vimeo in a 3.7+ site In the app, login in our master site. Open "MM Dev Testing Course > Resource: URL > Embedded URL to Vimeo video".  Check that the video is rendered. Inspect the iframe. Check that its src is master.mm.moodledemo.net/media/player/vimeo/wsplayer.php... Test Vimeo in a 3.5 site In the app, login in our 3.5 site. Open "Curso > Topic 1 > Embedded vimeo video". Check that the video is rendered. Inspect the iframe. Check that its src is player.vimeo.com. Test auto-login In the app, login in our master site. Open "MM Dev Testing Course > Resource: URL > Embedded URL to same site and NOT handled by the app (to test auto-login)". Check that the content is rendered without having to login. Notice 1: if you're using a student or teacher account you will see an error saying that you don't have permissions. Notice 2: This already worked before, but the code was refactored a bit.
    • MOODLE_402_STABLE
    • MOODLE_402_STABLE
    • Moodle App 4.2.0

    Description

      When a Vimeo is included in some Moodle's HTML, we treat is so private videos can be played in the app. This isn't done for mod_url though, so private Vimeo videos don't work there.

      This should probably be handled in core-iframe too so it's applied to everywhere using this component.

      Attachments

        1. screenshot-1.png
          screenshot-1.png
          303 kB
        2. screenshot-2.png
          screenshot-2.png
          336 kB
        3. screenshot-3.png
          screenshot-3.png
          569 kB

        Activity

          People

            dpalou Dani Palou
            dpalou Dani Palou
            Noel De Martin Noel De Martin
            Juan Leyva Juan Leyva
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Clockify

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.