Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-4479

Let site plugins use core-course-module-info

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • 4.3.0
    • Site add-ons
    • Hide

      This issue only needs to be tested in 1 device.

      I uploaded a modified version of choicegroup to our master site to be able to test this properly.

      1. Login as a student in our master site and open any activity 3rd party plugin except group choice (e.g. questionnaire, customcert, etc.). Check that the plugins behave as it used to: it has the "big title" at the top and the activity description is shown below the completion buttons (if any), outside of the grey box.
      2. Now go to course "Group choice course" and open the activity "Select your group". Check that you see the "big title" and the activity description is inside the grey box below the title. 
      3. Go offline and answer the group choice. Check that you see a warning saying that there is offline data to be synchronized.
      Show
      This issue only needs to be tested in 1 device. I uploaded a modified version of choicegroup to our master site to be able to test this properly. Login as a student in our master site and open any activity 3rd party plugin except group choice (e.g. questionnaire, customcert, etc.). Check that the plugins behave as it used to: it has the "big title" at the top and the activity description is shown below the completion buttons (if any), outside of the grey box. Now go to course "Group choice course" and open the activity "Select your group". Check that you see the "big title" and the activity description is inside the grey box below the title.  Go offline and answer the group choice. Check that you see a warning saying that there is offline data to be synchronized.
    • MOODLE_403_STABLE
    • Moodle Apps - 2023 Sprint i4.2, Moodle Apps - 2024 i1, Moodle Apps - 2024 i1.1

    Description

      Right now, the app always add core-course-module-info for site plugins to have a more consistent UI. But the app only has part of the info, e.g. we cannot include the activity description in there so the plugin is the one that needs to display it (using core-module-description, which is deprecated).

      If a module tries to use core-course-module-info then the module-info component is displayed twice because the app already adds it in the page. The app should only add this component if the plugin doesn't do it already.

      One of the possibilities we discussed was using Angular content projection to detect if the plugin template contains core-course-module-info and project it to the top of the content. I did a quick test, but Angular wasn't able to find the component inside the plugin content because the template is compiled dynamically. So we decided to keep it simple and just check if the template contains the component, without projection.

      Attachments

        Activity

          People

            dpalou Dani Palou
            dpalou Dani Palou
            Pau Ferrer Pau Ferrer
            Isabel Renedo Rouco Isabel Renedo Rouco
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Clockify

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.