Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-4509

Review the download of files embedded in HTML content

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • DEV backlog
    • Offline

    Description

      Right now, in most places of the app we only download the files included in the file area (e.g. introfiles), but it's possible that the HTML content also includes embedded content belonging to external sites. These external files won't be downloaded when downloading the activity/section/course.

      The function that can extract files from HTML content (extractDownloadableFilesFromHtml) is only used in a few cases (usually when we don't have the list of files), and it only downloads files that are hosted in the same site. This is different than what core-external-content does, this directive downloads all files when they are embedded (except if they are too large), the only case where we check if it's an internal file is for anchors (<a>).

      We should review if we want to improve this to allow downloading external files. Also, this function probably should be improved to allow downloading embedded PDFs (MOBILE-4173).

      Attachments

        Activity

          People

            Unassigned Unassigned
            dpalou Dani Palou
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Clockify

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.