Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-4716

data-open-in attribute in links no longer working with app 4.5

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.5.0
    • Others
    • Hide

      This issue only needs to be tested in 1 device.

      1. Click a link that has data-open-in="app" and check that the app opens the link in inapp browser. You have one in master site > MM Dev course > General > Link to google opened in InAppBrowser in the app.
      2. Click a link without the data attribute and check that the app opens the link in system browser (e.g. Chrome or Safari). You have one in master site > MM Dev course > General > Normal link to google (opened in browser).
      Show
      This issue only needs to be tested in 1 device. Click a link that has data-open-in="app" and check that the app opens the link in inapp browser. You have one in master site > MM Dev course > General > Link to google opened in InAppBrowser in the app. Click a link without the data attribute and check that the app opens the link in system browser (e.g. Chrome or Safari). You have one in master site > MM Dev course > General > Normal link to google (opened in browser).
    • MOODLE_405_STABLE
    • Moodle Apps - 2024 i4.2, Moodle Apps - 2024 i4.3

      In app 4.5, we applied a transform to most boolean inputs. Along with the transform, in many cases we also added an initial value.

      In core-link, now the inApp input will always have a boolean value (true/false) because it is initialized to false. But in the implementation, we only check the "data-open-in" attribute if the inApp input is undefined, so the data attribute no longer works.

      We should review all the boolean inputs where we added an initial value, and remove the initial value if the input could be undefined.

        1. MOBILE-4716_step1_pageNotLoaded.png
          MOBILE-4716_step1_pageNotLoaded.png
          97 kB

            dpalou Dani Palou
            dpalou Dani Palou
            Pau Ferrer Pau Ferrer
            Isabel Renedo Rouco Isabel Renedo Rouco
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 10 minutes
                10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.