Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-4723

Disabling all blocks makes myoverview disappear (4.4 regression)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.4.0, 4.5.0
    • Others
    • Hide

      Test on any device of your choice.

      1. On any site, go to disabled features and disable General > Blocks.
      2. Enter the app and check on My courses tab, the My overview block is COMPLETELY SHOWN.
      Show
      Test on any device of your choice. On any site, go to disabled features and disable General > Blocks. Enter the app and check on My courses tab, the My overview block is COMPLETELY SHOWN.
    • MOODLE_404_STABLE, MOODLE_405_STABLE
    • Moodle Apps - 2024 i4.3, Moodle Apps - 2025 i1

      Due to the delegates refactor done in MOBILE-4498 and this commit, this stopped working as it used to.

      In blocks delegate, we override the isFeatureDisabled function to allow using myoverview even if all blocks are disabled. But now, with the refactor, if all blocks are disabled then isEnabled returns false in blocks delegate, so the execution of updateHandlers stops before treating the handlers.

        1. MOBILE-4723-reproduce-step1.png
          MOBILE-4723-reproduce-step1.png
          20 kB
        2. MOBILE-4723-reproduce-step2.png
          MOBILE-4723-reproduce-step2.png
          67 kB

            pferre22 Pau Ferrer
            dpalou Dani Palou
            Dani Palou Dani Palou
            Isabel Renedo Rouco Isabel Renedo Rouco
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 5 hours, 59 minutes
                2d 5h 59m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.