-
Sub-task
-
Resolution: Fixed
-
Minor
-
2.0
-
-
MOODLE_20_STABLE
-
MOODLE_20_STABLE
We have to decide what we want to do about the loading as I have found a little issue with it just now.
As we need to wrap $mmUtil.showModalLoading() within a $translate, it becomes async, which means that sometimes we could call $mmUtil.closeModalLoading() as it's not displayed yet.
If we agree that throughout the whole app we're going to use that kind of loading:
- Do we want to block any input during the loading?
- What happens for things that should load in the background?
- Is that style correct? How does a user cancels an action that lasts for too long?
If we do agree on keeping $ionicLoading for now, we should refactor the $mmUtil implementation to return an object that can close the popup, or cancel its opening.
We should also look into adding a default "Loading" string, and support $translate from within $mmUtil rather than asking to pass the string around. "Loading" should be the string to use except in some rare occasions ("Downloading", "Uploading", ...).
- blocks
-
MOBILE-1035 Style and animate mm-loading
-
- Closed
-
- has a non-specific relationship to
-
MOBILE-973 Migrate: contents/sections to a sections components
-
- Closed
-