From 8b920ba19da25c385bbdfb226a5ddbb5cfdd507b Mon Sep 17 00:00:00 2001
From: Andrew Nicols <andrew@nicols.co.uk>
Date: Tue, 23 May 2023 09:51:30 +0800
Subject: [PATCH 1/1] MDL-74954 core: Detect changes to hook overrides

---
 lib/classes/hook/manager.php | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/lib/classes/hook/manager.php b/lib/classes/hook/manager.php
index 3b0c1666db..4bc1140b44 100644
--- a/lib/classes/hook/manager.php
+++ b/lib/classes/hook/manager.php
@@ -286,7 +286,12 @@ final class manager implements
             $cache = \cache::make('core', 'hookcallbacks');
             $callbacks = $cache->get('callbacks');
             $deprecations = $cache->get('deprecations');
-            if (is_array($callbacks) && is_array($deprecations)) {
+            $overrideshash = $cache->get('overrideshash');
+
+            $usecache = is_array($callbacks);
+            $usecache = $usecache && is_array($deprecations);
+            $usecache = $usecache && $this->calculate_overrides_hash() === $overrideshash;
+            if ($usecache) {
                 $this->allcallbacks = $callbacks;
                 $this->alldeprecations = $deprecations;
                 return;
@@ -314,6 +319,7 @@ final class manager implements
         if ($cache) {
             $cache->set('callbacks', $this->allcallbacks);
             $cache->set('deprecations', $this->alldeprecations);
+            $cache->set('overrideshash', $this->calculate_overrides_hash());
         }
     }
 
@@ -393,6 +399,28 @@ final class manager implements
         }
     }
 
+    /**
+     * Calculate a hash of the overrides.
+     * This is used to inform if the overrides have changed, which invalidates the cache.
+     *
+     * Overrides are only configured in config.php where there is no other mechanism to invalidate the cache.
+     *
+     * @return null|string
+     */
+    private function calculate_overrides_hash(): ?string {
+        global $CFG;
+
+        if (!property_exists($CFG, 'hooks_callback_overrides')) {
+            return null;
+        }
+
+        if (!is_iterable($CFG->hooks_callback_overrides)) {
+            return null;
+        }
+
+        return sha1(json_encode($CFG->hooks_callback_overrides));
+    }
+
     /**
      * Prioritise the callbacks.
      */
-- 
2.39.0