--- Learn.Ed/mod/assignment/lib.php 2009-08-17 06:07:06.000000000 -0500 +++ LearnDev.ed/mod/assignment/lib.php 2009-09-01 14:54:58.000000000 -0500 @@ -557,7 +557,7 @@ class assignment_base { //for fast grade, we need to check if any changes take place $updatedb = false; - if ($grading) { + if ($grading && isset($_POST['changecheck']) && $_POST['changecheck'][$id] == 1 ) { $grade = $_POST['menu'][$id]; $updatedb = $updatedb || ($submission->grade != $grade); $submission->grade = $grade; @@ -566,7 +566,7 @@ class assignment_base { unset($submission->grade); // Don't need to update this. } } - if ($commenting) { + if ($commenting && isset($_POST['changecheck']) && $_POST['changecheck'][$id] == 1 ) { $commentvalue = trim($_POST['submissioncomment'][$id]); $updatedb = $updatedb || ($submission->submissioncomment != stripslashes($commentvalue)); $submission->submissioncomment = $commentvalue; @@ -1204,7 +1204,7 @@ class assignment_base { } else if ($quickgrade) { $menu = choose_from_menu(make_grades_menu($this->assignment->grade), 'menu['.$auser->id.']', $auser->grade, - get_string('nograde'),'',-1,true,false,$tabindex++); + get_string('nograde'), 'document.getElementById(\'changecheck_' . $auser->id . '\').value = 1;',-1,true,false,$tabindex++); $grade = '
'. $menu .'
'; } else { $grade = '
'.$this->display_grade($auser->grade).'
'; @@ -1217,7 +1217,7 @@ class assignment_base { } else if ($quickgrade) { $menu = choose_from_menu(make_grades_menu($this->assignment->grade), 'menu['.$auser->id.']', $auser->grade, - get_string('nograde'),'',-1,true,false,$tabindex++); + get_string('nograde'),'document.getElementById(\'changecheck_' . $auser->id . '\').value = 1;',-1,true,false,$tabindex++); $grade = '
'.$menu.'
'; } else { $grade = '
'.$this->display_grade($auser->grade).'
'; @@ -1230,7 +1230,7 @@ class assignment_base { } else if ($quickgrade) { $comment = '
' . '
'; + . $auser->id.'" rows="2" cols="20" onchange="document.getElementById(\'changecheck_' . $auser->id . '\').value = 1;">'.($auser->submissioncomment).''; } else { $comment = '
'.shorten_text(strip_tags($auser->submissioncomment),15).'
'; } @@ -1244,7 +1244,7 @@ class assignment_base { } else if ($quickgrade) { // allow editing $menu = choose_from_menu(make_grades_menu($this->assignment->grade), 'menu['.$auser->id.']', $auser->grade, - get_string('nograde'),'',-1,true,false,$tabindex++); + get_string('nograde'),'document.getElementById(\'changecheck_' . $auser->id . '\').value = 1;',-1,true,false,$tabindex++); $grade = '
'.$menu.'
'; } else { $grade = '
-
'; @@ -1255,12 +1255,17 @@ class assignment_base { } else if ($quickgrade) { $comment = '
' . '
'; + . $auser->id.'" rows="2" cols="20"' + . ' onchange="document.getElementById(\'changecheck_' . $auser->id . '\').value = 1;" >'.($auser->submissioncomment).''; } else { $comment = '
 
'; } } - + + if ($quickgrade) { + $grade .= ''; + } + if (empty($auser->status)) { /// Confirm we have exclusively 0 or 1 $auser->status = 0; } else { @@ -1367,7 +1372,7 @@ class assignment_base { /** * Process teacher feedback submission * - * This is called by submissions() when a grading even has taken place. + * This is called by submissions() when a grading event has taken place. * It gets its data from the submitted form. * @return object The updated submission object */