<?xml version="1.0"?>
<smurf version="0.9.0"><check title="Coding style problems" url="http://docs.moodle.org/dev/Coding_style"><description>This sections shows the coding style problems detected in the code by phpcs</description><mess><problem file="question/engine/simpletest/testquestionusagebyactivity.php" linefrom="174" lineto="174" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.TooLong" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Line exceeds 132 characters; contains 136 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testquestionusagebyactivity.php" linefrom="175" lineto="175" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.TooLong" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Line exceeds 132 characters; contains 177 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testquestionusagebyactivity.php" linefrom="176" lineto="176" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 188 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testquestionusagebyactivity.php" linefrom="177" lineto="177" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 207 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testquestionusagebyactivity.php" linefrom="178" lineto="178" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 198 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testquestionusagebyactivity.php" linefrom="179" lineto="179" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 198 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testquestionusagebyactivity.php" linefrom="180" lineto="180" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 198 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="98" lineto="98" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.ScopeClosingBrace.Indent" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Closing brace indented incorrectly; expected 4 spaces, found 5</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="100" lineto="100" method="" class="" package="" api="" ruleset="moodle" rule="NamingConventions.ValidFunctionName" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Public method name "question_engine_unit_of_work_test::testDown" must be in lower-case letters only</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="118" lineto="118" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.TooLong" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Line exceeds 132 characters; contains 137 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="119" lineto="119" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.TooLong" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Line exceeds 132 characters; contains 178 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="120" lineto="120" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 188 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="121" lineto="121" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 207 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="122" lineto="122" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 198 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="123" lineto="123" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 202 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="124" lineto="124" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 198 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="125" lineto="125" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 198 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="126" lineto="126" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 198 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="127" lineto="127" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 202 characters</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="128" lineto="128" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 198 characters</message><description/><code/></problem></mess></check><check title="PHPDocs style problems" url="http://docs.moodle.org/dev/Coding_style"><description>This sections shows the phpdocs problems detected in the code by local_moodlecheck</description><mess><problem file="question/engine/datalib.php" linefrom="1066" lineto="1066" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work::notify_step_added is not documented</message><description/><code/></problem><problem file="question/engine/datalib.php" linefrom="1097" lineto="1097" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work::notify_step_modified is not documented</message><description/><code/></problem><problem file="question/engine/datalib.php" linefrom="1118" lineto="1118" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work::notify_step_deleted is not documented</message><description/><code/></problem><problem file="question/engine/datalib.php" linefrom="1140" lineto="1140" method="" class="" package="" api="" ruleset="moodle" rule="functiondescription" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>There is no description in phpdocs for function is_step_added</message><description/><code/></problem><problem file="question/engine/datalib.php" linefrom="1155" lineto="1155" method="" class="" package="" api="" ruleset="moodle" rule="functiondescription" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>There is no description in phpdocs for function is_step_modified</message><description/><code/></problem><problem file="question/engine/datalib.php" linefrom="1170" lineto="1170" method="" class="" package="" api="" ruleset="moodle" rule="functiondescription" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>There is no description in phpdocs for function is_step_deleted</message><description/><code/></problem><problem file="question/engine/datalib.php" linefrom="182" lineto="182" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function question_engine_data_mapper::update_question_attempt_step has incomplete parameters list</message><description/><code/></problem><problem file="question/engine/questionattempt.php" linefrom="1293" lineto="1293" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_attempt_with_restricted_history::set_slot is not documented</message><description/><code/></problem><problem file="question/engine/questionattempt.php" linefrom="219" lineto="219" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function question_attempt::set_observer has incomplete parameters list</message><description/><code/></problem><problem file="question/engine/questionattemptstep.php" linefrom="129" lineto="129" method="" class="" package="" api="" ruleset="moodle" rule="functiondescription" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>There is no description in phpdocs for function get_id</message><description/><code/></problem><problem file="question/engine/questionusage.php" linefrom="863" lineto="863" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_usage_null_observer::notify_step_modified is not documented</message><description/><code/></problem><problem file="question/engine/questionusage.php" linefrom="865" lineto="865" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_usage_null_observer::notify_step_deleted is not documented</message><description/><code/></problem><problem file="question/engine/questionusage.php" linefrom="139" lineto="139" method="" class="" package="" api="" ruleset="moodle" rule="functiondescription" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>There is no description in phpdocs for function get_observer</message><description/><code/></problem><problem file="question/engine/questionusage.php" linefrom="147" lineto="147" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function question_usage_by_activity::set_observer has incomplete parameters list</message><description/><code/></problem><problem file="question/engine/simpletest/testquestionattempt.php" linefrom="73" lineto="73" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_attempt_test::test_get_set_slot is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testquestionusagebyactivity.php" linefrom="170" lineto="170" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_usage_db_test::test_load is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="41" lineto="41" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function testable_question_engine_unit_of_work::get_modified is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="45" lineto="45" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function testable_question_engine_unit_of_work::get_attempts_added is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="49" lineto="49" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function testable_question_engine_unit_of_work::get_attempts_modified is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="53" lineto="53" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function testable_question_engine_unit_of_work::get_steps_added is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="57" lineto="57" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function testable_question_engine_unit_of_work::get_steps_modified is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="61" lineto="61" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function testable_question_engine_unit_of_work::get_steps_deleted is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="83" lineto="83" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::setUp is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="100" lineto="100" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::testDown is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="104" lineto="104" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::setup_initial_test_state is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="114" lineto="114" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::get_test_data is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="132" lineto="132" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::test_initial_state is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="141" lineto="141" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::test_update_usage is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="148" lineto="148" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::test_add_question is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="158" lineto="158" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::test_add_and_start_question is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="175" lineto="175" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::test_process_action is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="196" lineto="196" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::test_regrade_same_steps is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="223" lineto="223" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::test_regrade_losing_steps is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="259" lineto="259" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function question_engine_unit_of_work_test::test_tricky_regrade is not documented</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="33" lineto="33" method="" class="" package="" api="" ruleset="moodle" rule="phpdocsfistline" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>No one-line description found in phpdocs for class testable_question_engine_unit_of_work</message><description/><code/></problem><problem file="question/engine/simpletest/testunitofwork.php" linefrom="20" lineto="20" method="" class="" package="" api="" ruleset="moodle" rule="packagevalid" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Package moodlecore is not valid</message><description/><code/></problem></mess></check></smurf>
