<?xml version="1.0"?>
<smurf version="0.9.0"><check title="Coding style problems" url="http://docs.moodle.org/dev/Coding_style"><description>This sections shows the coding style problems detected in the code by phpcs</description><mess><problem file="admin/webservice/testclient_forms.php" linefrom="739" lineto="739" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NotCapital" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must start with a capital letter, digit or 3-dots sequence</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="739" lineto="739" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="739" lineto="739" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NoSpaceBefore" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No space before comment text; expected "// note: these values are intentionally PARAM_RAW - we want users to test any rubbish as parameters" but found "//note: these values are intentionally PARAM_RAW - we want users to test any rubbish as parameters"</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="744" lineto="744" method="" class="" package="" api="" ruleset="moodle" rule="ControlStructures.ControlSignature" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected "} else if (...) {\n"; found "} else  if (...) {\n"</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="768" lineto="768" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NotCapital" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must start with a capital letter, digit or 3-dots sequence</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="768" lineto="768" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="785" lineto="785" method="" class="" package="" api="" ruleset="Generic" rule="ControlStructures.InlineControlStructure.NotAllowed" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Inline control structures are not allowed</message><description/><code/></problem><problem file="course/externallib.php" linefrom="595" lineto="595" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="596" lineto="596" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="597" lineto="597" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="598" lineto="598" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="599" lineto="599" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="604" lineto="604" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="course/externallib.php" linefrom="618" lineto="618" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="course/externallib.php" linefrom="627" lineto="627" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="course/externallib.php" linefrom="628" lineto="628" method="" class="" package="" api="" ruleset="Generic" rule="ControlStructures.InlineControlStructure.NotAllowed" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Inline control structures are not allowed</message><description/><code/></problem><problem file="course/externallib.php" linefrom="628" lineto="628" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.SuperfluousWhitespace.EndLine" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Whitespace found at end of line</message><description/><code/></problem><problem file="course/externallib.php" linefrom="632" lineto="632" method="" class="" package="" api="" ruleset="moodle" rule="WhiteSpace.WhiteSpaceInStrings.TabWhitespace" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Tab found within whitespace</message><description/><code/></problem><problem file="course/externallib.php" linefrom="632" lineto="632" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.SuperfluousWhitespace.EndLine" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Whitespace found at end of line</message><description/><code/></problem><problem file="course/externallib.php" linefrom="634" lineto="634" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="635" lineto="635" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="636" lineto="636" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="637" lineto="637" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/lib.php" linefrom="3498" lineto="3498" method="" class="" package="" api="" ruleset="Generic" rule="ControlStructures.InlineControlStructure.NotAllowed" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Inline control structures are not allowed</message><description/><code/></problem><problem file="course/lib.php" linefrom="3502" lineto="3502" method="" class="" package="" api="" ruleset="Generic" rule="ControlStructures.InlineControlStructure.NotAllowed" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Inline control structures are not allowed</message><description/><code/></problem><problem file="course/lib.php" linefrom="3512" lineto="3512" method="" class="" package="" api="" ruleset="Generic" rule="ControlStructures.InlineControlStructure.NotAllowed" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Inline control structures are not allowed</message><description/><code/></problem><problem file="course/lib.php" linefrom="3523" lineto="3523" method="" class="" package="" api="" ruleset="Generic" rule="ControlStructures.InlineControlStructure.NotAllowed" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Inline control structures are not allowed</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1704" lineto="1704" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.DocBlock" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1714" lineto="1714" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1745" lineto="1745" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1760" lineto="1760" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1784" lineto="1784" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1788" lineto="1788" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.SuperfluousWhitespace.EmptyLines" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Functions must not contain multiple empty lines in a row; found 2 empty lines</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1792" lineto="1792" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1796" lineto="1796" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.SuperfluousWhitespace.EmptyLines" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Functions must not contain multiple empty lines in a row; found 2 empty lines</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1811" lineto="1811" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1816" lineto="1816" method="" class="" package="" api="" ruleset="moodle" rule="ControlStructures.ControlSignature" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected "try {\n...} catch (...) {\n"; found "try {\n...}\n        catch (...) {\n"</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1824" lineto="1824" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1828" lineto="1828" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.SuperfluousWhitespace.EmptyLines" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Functions must not contain multiple empty lines in a row; found 2 empty lines</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1841" lineto="1841" method="" class="" package="" api="" ruleset="moodle" rule="ControlStructures.ControlSignature" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected "try {\n...} catch (...) {\n"; found "try {\n...}\n        catch (...) {\n"</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="1849" lineto="1849" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem></mess></check><check title="PHPDocs style problems" url="http://docs.moodle.org/dev/Coding_style"><description>This sections shows the phpdocs problems detected in the code by local_moodlecheck</description><mess><problem file="admin/webservice/testclient_forms.php" linefrom="731" lineto="731" method="" class="" package="" api="" ruleset="moodle" rule="classesdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Class core_course_delete_categories_form is not documented</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="732" lineto="732" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function core_course_delete_categories_form::definition is not documented</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="764" lineto="764" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function core_course_delete_categories_form::get_params is not documented</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="731" lineto="731" method="" class="" package="" api="" ruleset="moodle" rule="packagespecified" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Package is not specified for class core_course_delete_categories_form. It is also not specified in file-level phpdocs</message><description/><code/></problem></mess></check></smurf>
