<?xml version="1.0"?>
<smurf version="0.9.0"><check title="Coding style problems" url="http://docs.moodle.org/dev/Coding_style"><description>This sections shows the coding style problems detected in the code by phpcs</description><mess><problem file="admin/webservice/testclient_forms.php" linefrom="739" lineto="739" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NotCapital" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must start with a capital letter, digit or 3-dots sequence</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="739" lineto="739" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="739" lineto="739" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NoSpaceBefore" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No space before comment text; expected "// note: these values are intentionally PARAM_RAW - we want users to test any rubbish as parameters" but found "//note: these values are intentionally PARAM_RAW - we want users to test any rubbish as parameters"</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="744" lineto="744" method="" class="" package="" api="" ruleset="moodle" rule="ControlStructures.ControlSignature" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected "} else if (...) {\n"; found "} else  if (...) {\n"</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="772" lineto="772" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NotCapital" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must start with a capital letter, digit or 3-dots sequence</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="772" lineto="772" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="course/externallib.php" linefrom="404" lineto="404" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="405" lineto="405" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="406" lineto="406" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="407" lineto="407" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="408" lineto="408" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="416" lineto="416" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.TooLong" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Line exceeds 132 characters; contains 146 characters</message><description/><code/></problem><problem file="course/externallib.php" linefrom="418" lineto="418" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.TooLong" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Line exceeds 132 characters; contains 133 characters</message><description/><code/></problem><problem file="course/externallib.php" linefrom="443" lineto="443" method="" class="" package="" api="" ruleset="moodle" rule="WhiteSpace.WhiteSpaceInStrings.TabWhitespace" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Tab found within whitespace</message><description/><code/></problem><problem file="course/externallib.php" linefrom="443" lineto="443" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.SuperfluousWhitespace.EndLine" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Whitespace found at end of line</message><description/><code/></problem><problem file="course/externallib.php" linefrom="445" lineto="445" method="" class="" package="" api="" ruleset="moodle" rule="ControlStructures.ControlSignature" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected "foreach (...) {\n"; found "foreach(...) {\n"</message><description/><code/></problem><problem file="course/externallib.php" linefrom="452" lineto="452" method="" class="" package="" api="" ruleset="moodle" rule="ControlStructures.ControlSignature" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected "} else {\n"; found "}\n            else {\n"</message><description/><code/></problem><problem file="course/externallib.php" linefrom="459" lineto="459" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NotCapital" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must start with a capital letter, digit or 3-dots sequence</message><description/><code/></problem><problem file="course/externallib.php" linefrom="459" lineto="459" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="course/externallib.php" linefrom="459" lineto="459" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NoSpaceBefore" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No space before comment text; expected "// same as in the course/editcategory.php" but found "//same as in the course/editcategory.php"</message><description/><code/></problem><problem file="course/externallib.php" linefrom="461" lineto="461" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NotCapital" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must start with a capital letter, digit or 3-dots sequence</message><description/><code/></problem><problem file="course/externallib.php" linefrom="461" lineto="461" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NoSpaceBefore" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No space before comment text; expected "// check id number" but found "//check id number"</message><description/><code/></problem><problem file="course/externallib.php" linefrom="462" lineto="462" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="course/externallib.php" linefrom="462" lineto="462" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NoSpaceBefore" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No space before comment text; expected "// same as in course/editcategory_form.php" but found "//same as in course/editcategory_form.php"</message><description/><code/></problem><problem file="course/externallib.php" linefrom="474" lineto="474" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NotCapital" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must start with a capital letter, digit or 3-dots sequence</message><description/><code/></problem><problem file="course/externallib.php" linefrom="474" lineto="474" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="course/externallib.php" linefrom="474" lineto="474" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NoSpaceBefore" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No space before comment text; expected "// check name" but found "//check name"</message><description/><code/></problem><problem file="course/externallib.php" linefrom="480" lineto="480" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="course/externallib.php" linefrom="480" lineto="480" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NoSpaceBefore" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No space before comment text; expected "// Format the description" but found "//Format the description"</message><description/><code/></problem><problem file="course/externallib.php" linefrom="493" lineto="493" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.SuperfluousWhitespace.EndLine" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Whitespace found at end of line</message><description/><code/></problem><problem file="course/externallib.php" linefrom="498" lineto="498" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NotCapital" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must start with a capital letter, digit or 3-dots sequence</message><description/><code/></problem><problem file="course/externallib.php" linefrom="498" lineto="498" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="course/externallib.php" linefrom="498" lineto="498" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NoSpaceBefore" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No space before comment text; expected "// populate special fields" but found "//populate special fields"</message><description/><code/></problem><problem file="course/externallib.php" linefrom="510" lineto="510" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="511" lineto="511" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="512" lineto="512" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="513" lineto="513" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="course/externallib.php" linefrom="514" lineto="514" method="" class="" package="" api="" ruleset="Squiz" rule="Commenting.DocCommentAlignment.SpaceBeforeAsterisk" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected 5 space(s) before asterisk; 4 found</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="252" lineto="252" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="256" lineto="256" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="263" lineto="263" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="271" lineto="271" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="275" lineto="275" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="277" lineto="277" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="282" lineto="282" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="287" lineto="287" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="289" lineto="289" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="295" lineto="295" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="304" lineto="304" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="307" lineto="307" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="312" lineto="312" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="325" lineto="325" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="328" lineto="328" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="336" lineto="336" method="" class="" package="" api="" ruleset="moodle" rule="ControlStructures.ControlSignature" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected "try {\n...} catch (...) {\n"; found "try {\n...}\n        catch (...) {\n"</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="343" lineto="343" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="346" lineto="346" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="351" lineto="351" method="" class="" package="" api="" ruleset="moodle" rule="ControlStructures.ControlSignature" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected "try {\n...} catch (...) {\n"; found "try {\n...}\n        catch (...) {\n"</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="358" lineto="358" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="361" lineto="361" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="365" lineto="365" method="" class="" package="" api="" ruleset="moodle" rule="ControlStructures.ControlSignature" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected "try {\n...} catch (...) {\n"; found "try {\n...}\n        catch (...) {\n"</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="372" lineto="372" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="375" lineto="375" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="379" lineto="379" method="" class="" package="" api="" ruleset="moodle" rule="ControlStructures.ControlSignature" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Expected "try {\n...} catch (...) {\n"; found "try {\n...}\n        catch (...) {\n"</message><description/><code/></problem><problem file="webservice/simpletest/testwebservice.php" linefrom="386" lineto="386" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.InvalidEndChar" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must end in  full-stops, exclamation marks, or question marks</message><description/><code/></problem></mess></check><check title="PHPDocs style problems" url="http://docs.moodle.org/dev/Coding_style"><description>This sections shows the phpdocs problems detected in the code by local_moodlecheck</description><mess><problem file="admin/webservice/testclient_forms.php" linefrom="731" lineto="731" method="" class="" package="" api="" ruleset="moodle" rule="classesdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Class core_course_create_categories_form is not documented</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="732" lineto="732" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function core_course_create_categories_form::definition is not documented</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="768" lineto="768" method="" class="" package="" api="" ruleset="moodle" rule="functionsdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Function core_course_create_categories_form::get_params is not documented</message><description/><code/></problem><problem file="admin/webservice/testclient_forms.php" linefrom="731" lineto="731" method="" class="" package="" api="" ruleset="moodle" rule="packagespecified" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Package is not specified for class core_course_create_categories_form. It is also not specified in file-level phpdocs</message><description/><code/></problem></mess></check></smurf>
