<?xml version="1.0"?>
<smurf version="0.9.0"><check title="Coding style problems" url="http://docs.moodle.org/dev/Coding_style"><description>This sections shows the coding style problems detected in the code by phpcs</description><mess><problem file="mod/assign/feedback/file/batchuploadfilesform.php" linefrom="41" lineto="41" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "definition"</message><description/><code/></problem><problem file="mod/assign/feedback/file/batchuploadfilesform.php" linefrom="56" lineto="56" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.TooLong" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Line exceeds 132 characters; contains 169 characters</message><description/><code/></problem><problem file="mod/assign/feedback/file/importzipform.php" linefrom="2" lineto="2" method="" class="" package="" api="" ruleset="moodle" rule="Files.BoilerplateComment.WrongWhitespace" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>The opening &lt;?php tag must be followed by exactly one newline.</message><description/><code/></problem><problem file="mod/assign/feedback/file/importzipform.php" linefrom="43" lineto="43" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "definition"</message><description/><code/></problem><problem file="mod/assign/feedback/file/importzipform.php" linefrom="61" lineto="61" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.SuperfluousWhitespace.EmptyLines" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Functions must not contain multiple empty lines in a row; found 2 empty lines</message><description/><code/></problem><problem file="mod/assign/feedback/file/importzipform.php" linefrom="112" lineto="112" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.SuperfluousWhitespace.EmptyLines" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Functions must not contain multiple empty lines in a row; found 2 empty lines</message><description/><code/></problem><problem file="mod/assign/feedback/file/importziplib.php" linefrom="272" lineto="272" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.SuperfluousWhitespace.EmptyLines" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Functions must not contain multiple empty lines in a row; found 2 empty lines</message><description/><code/></problem><problem file="mod/assign/feedback/file/locallib.php" linefrom="189" lineto="189" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.MaxExceeded" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line exceeds maximum limit of 180 characters; contains 182 characters</message><description/><code/></problem><problem file="mod/assign/feedback/file/locallib.php" linefrom="395" lineto="395" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.SuperfluousWhitespace.EmptyLines" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Functions must not contain multiple empty lines in a row; found 2 empty lines</message><description/><code/></problem><problem file="mod/assign/feedback/file/locallib.php" linefrom="455" lineto="455" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "view_upload_zip"</message><description/><code/></problem><problem file="mod/assign/feedback/file/uploadzipform.php" linefrom="27" lineto="27" method="" class="" package="" api="" ruleset="moodle" rule="PHP.IncludingFile.BracketsNotRequired" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>"require_once" must be immediately followed by an open parenthesis</message><description/><code/></problem><problem file="mod/assign/feedback/file/uploadzipform.php" linefrom="40" lineto="40" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "definition"</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradesform.php" linefrom="2" lineto="2" method="" class="" package="" api="" ruleset="moodle" rule="Files.BoilerplateComment.WrongWhitespace" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>The opening &lt;?php tag must be followed by exactly one newline.</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradesform.php" linefrom="43" lineto="43" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "definition"</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="2" lineto="2" method="" class="" package="" api="" ruleset="moodle" rule="Files.BoilerplateComment.WrongWhitespace" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>The opening &lt;?php tag must be followed by exactly one newline.</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="66" lineto="66" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "__construct"</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="77" lineto="77" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "parsecsv"</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="87" lineto="87" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "init"</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="148" lineto="148" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "next"</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="181" lineto="181" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "close"</message><description/><code/></problem><problem file="mod/assign/feedback/offline/locallib.php" linefrom="327" lineto="327" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NotCapital" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Inline comments must start with a capital letter, digit or 3-dots sequence</message><description/><code/></problem><problem file="mod/assign/feedback/offline/locallib.php" linefrom="327" lineto="327" method="" class="" package="" api="" ruleset="moodle" rule="Commenting.InlineComment.NoSpaceBefore" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No space before comment text; expected "// name of new zip file." but found "//name of new zip file."</message><description/><code/></problem><problem file="mod/assign/feedback/offline/uploadgradesform.php" linefrom="27" lineto="27" method="" class="" package="" api="" ruleset="moodle" rule="PHP.IncludingFile.BracketsNotRequired" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>"require_once" must be immediately followed by an open parenthesis</message><description/><code/></problem><problem file="mod/assign/feedback/offline/uploadgradesform.php" linefrom="40" lineto="40" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "definition"</message><description/><code/></problem><problem file="mod/assign/gradingtable.php" linefrom="75" lineto="75" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "__construct"</message><description/><code/></problem><problem file="mod/assign/gradingtable.php" linefrom="342" lineto="342" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "col_scale"</message><description/><code/></problem><problem file="mod/assign/gradingtable.php" linefrom="538" lineto="538" method="" class="" package="" api="" ruleset="Squiz" rule="Scope.MethodScope.Missing" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>No scope modifier specified for function "col_grademax"</message><description/><code/></problem><problem file="mod/assign/gradingtable.php" linefrom="539" lineto="539" method="" class="" package="" api="" ruleset="moodle" rule="WhiteSpace.SpaceAfterComma.NoSpace" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Commas (,) must be followed by white space.</message><description/><code/></problem><problem file="mod/assign/locallib.php" linefrom="426" lineto="426" method="" class="" package="" api="" ruleset="Squiz" rule="WhiteSpace.ScopeClosingBrace.Indent" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Closing brace indented incorrectly; expected 8 spaces, found 9</message><description/><code/></problem><problem file="mod/assign/locallib.php" linefrom="426" lineto="426" method="" class="" package="" api="" ruleset="Generic" rule="WhiteSpace.ScopeIndent.Incorrect" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Line indented incorrectly; expected 8 spaces, found 9</message><description/><code/></problem><problem file="mod/assign/locallib.php" linefrom="1810" lineto="1810" method="" class="" package="" api="" ruleset="moodle" rule="WhiteSpace.SpaceAfterComma.NoSpace" url="http://docs.moodle.org/dev/Coding_style" weight="5"><message>Commas (,) must be followed by white space.</message><description/><code/></problem><problem file="mod/assign/locallib.php" linefrom="1836" lineto="1836" method="" class="" package="" api="" ruleset="moodle" rule="Files.LineLength.TooLong" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Line exceeds 132 characters; contains 134 characters</message><description/><code/></problem></mess></check><check title="PHPDocs style problems" url="http://docs.moodle.org/dev/Coding_style"><description>This sections shows the phpdocs problems detected in the code by local_moodlecheck</description><mess><problem file="mod/assign/assignmentplugin.php" linefrom="366" lineto="366" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assign_plugin::set_editor_format has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/feedbackplugin.php" linefrom="145" lineto="145" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assign_feedback_plugin::grading_action has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/feedbackplugin.php" linefrom="154" lineto="154" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assign_feedback_plugin::grading_batch_operation has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/feedback/file/importziplib.php" linefrom="31" lineto="31" method="" class="" package="" api="" ruleset="moodle" rule="packagevalid" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Package asignfeedback_file is not valid</message><description/><code/></problem><problem file="mod/assign/feedback/file/importziplib.php" linefrom="40" lineto="40" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assignfeedback_file_zip_importer::is_valid_filename_for_import has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/feedback/file/importzipform.php" linefrom="2" lineto="2" method="" class="" package="" api="" ruleset="moodle" rule="noemptysecondline" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Empty line found after PHP open tag</message><description/><code/></problem><problem file="mod/assign/feedback/file/importzipform.php" linefrom="38" lineto="38" method="" class="" package="" api="" ruleset="moodle" rule="classesdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Class assignfeedback_file_import_zip_form is not documented</message><description/><code/></problem><problem file="mod/assign/feedback/file/renderable.php" linefrom="47" lineto="47" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assignfeedback_file_import_summary::__construct has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/feedback/file/locallib.php" linefrom="82" lineto="82" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assign_feedback_file::copy_area_files has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/feedback/file/batchuploadfilesform.php" linefrom="20" lineto="20" method="" class="" package="" api="" ruleset="moodle" rule="packagevalid" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Package mod_assign is not valid</message><description/><code/></problem><problem file="mod/assign/feedback/file/batchuploadfilesform.php" linefrom="33" lineto="33" method="" class="" package="" api="" ruleset="moodle" rule="packagevalid" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Package mod_assign is not valid</message><description/><code/></problem><problem file="mod/assign/feedback/offline/lang/en/assignfeedback_offline.php" linefrom="20" lineto="20" method="" class="" package="" api="" ruleset="moodle" rule="packagevalid" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Package assignfeedback_file is not valid</message><description/><code/></problem><problem file="mod/assign/feedback/offline/version.php" linefrom="20" lineto="20" method="" class="" package="" api="" ruleset="moodle" rule="packagevalid" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Package assignfeedback_file is not valid</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="2" lineto="2" method="" class="" package="" api="" ruleset="moodle" rule="noemptysecondline" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Empty line found after PHP open tag</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="35" lineto="35" method="" class="" package="" api="" ruleset="moodle" rule="classesdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Class assignfeedback_offline_grade_importer is not documented</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="64" lineto="64" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assignfeedback_offline_grade_importer::__construct has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="71" lineto="71" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assignfeedback_offline_grade_importer::parsecsv has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="37" lineto="37" method="" class="" package="" api="" ruleset="moodle" rule="variableshasvar" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for variable assignfeedback_offline_grade_importer::$importid does not contain @var or incorrect</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradeslib.php" linefrom="145" lineto="145" method="" class="" package="" api="" ruleset="moodle" rule="phpdocsnotrecommendedtag" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Not recommended phpdocs tag @global used</message><description/><code/></problem><problem file="mod/assign/feedback/offline/locallib.php" linefrom="33" lineto="33" method="" class="" package="" api="" ruleset="moodle" rule="packagevalid" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Package asignfeedback_offline is not valid</message><description/><code/></problem><problem file="mod/assign/feedback/offline/locallib.php" linefrom="70" lineto="70" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assign_feedback_offline::process_import_grades has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradesform.php" linefrom="2" lineto="2" method="" class="" package="" api="" ruleset="moodle" rule="noemptysecondline" url="http://docs.moodle.org/dev/Coding_style" weight="1"><message>Empty line found after PHP open tag</message><description/><code/></problem><problem file="mod/assign/feedback/offline/importgradesform.php" linefrom="38" lineto="38" method="" class="" package="" api="" ruleset="moodle" rule="classesdocumented" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Class assignfeedback_offline_import_grades_form is not documented</message><description/><code/></problem><problem file="mod/assign/feedback/comments/locallib.php" linefrom="116" lineto="116" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assign_feedback_comments::get_editor_text has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/feedback/comments/locallib.php" linefrom="134" lineto="134" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assign_feedback_comments::set_editor_text has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/locallib.php" linefrom="2435" lineto="2435" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assign::process_grading_batch_operation has incomplete parameters list</message><description/><code/></problem><problem file="mod/assign/locallib.php" linefrom="4418" lineto="4418" method="" class="" package="" api="" ruleset="moodle" rule="functionarguments" url="http://docs.moodle.org/dev/Coding_style" weight="3"><message>Phpdocs for function assign::get_user_id_for_uniqueid_static has incomplete parameters list</message><description/><code/></problem></mess></check></smurf>
