From 49f7fadae972591debf3e33ed71b0c76ab2200f7 Mon Sep 17 00:00:00 2001 From: Russell Smith Date: Sun, 24 Feb 2013 02:03:19 +1100 Subject: [PATCH] MDL-38173 Course: Use the correct module id's when adding to a section When course completion is on, $mod->id is the instance, not the course_module id. In add_to_section $mod->coursemodule must be used. --- course/lib.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/course/lib.php b/course/lib.php index 3a5f6fd..b19c470 100644 --- a/course/lib.php +++ b/course/lib.php @@ -2855,7 +2855,7 @@ function add_mod_to_section($mod, $beforemod=NULL) { } $DB->set_field("course_sections", "sequence", $newsequence, array("id"=>$section->id)); - $DB->set_field("course_modules", "section", $section->id, array("id" => $mod->id)); + $DB->set_field("course_modules", "section", $section->id, array("id" => $mod->coursemodule)); return $section->id; // Return course_sections ID that was used. } else { // Insert a new record @@ -2866,7 +2866,7 @@ function add_mod_to_section($mod, $beforemod=NULL) { $section->summaryformat = FORMAT_HTML; $section->sequence = $mod->coursemodule; $section->id = $DB->insert_record("course_sections", $section); - $DB->set_field("course_modules", "section", $section->id, array("id" => $mod->id)); + $DB->set_field("course_modules", "section", $section->id, array("id" => $mod->coursemodule)); return $section->id; } } -- 1.7.11.4