Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30623

Guest are continually asked for an enrolment password when trying to enter courses they should have access to

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2.1
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide

      1/ use DB editor and set some enrol->password fields from guest plugin to NULL
      2/ make sure user can not access
      3/ upgrade and verify guest access is now possible
      4/ try upgrade from 1.9

      Show
      1/ use DB editor and set some enrol->password fields from guest plugin to NULL 2/ make sure user can not access 3/ upgrade and verify guest access is now possible 4/ try upgrade from 1.9
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w50_MDL-30623_m23_guest
    • Pull Master Diff URL:

      Description

      MDL-30148 added 3 tighter checks on $instance->password in enrol/guest/lib.php

      eg

      -        if (empty($instance->password)) {
      		 
      +        if ($instance->password === '') {

      Since the default value of this field in the database is actually NULL this now breaks sites like moodle.org with a lot of guest access by forcing everyone to type a guest password.

        Attachments

          Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30148 improve password guest access

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              dougiamas Martin Dougiamas
              Integrator:
              Sam Hemelryk
              Tester:
              Gerard Caulfield
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jan/12