Remove unused lib/pear/XML/

Field Tab

Scrum

Time Tracking

Field Tab

Scrum

Time Tracking

Description

While doing a php lint across the codebase I noticed this:

PHP Strict standards:  Redefining already defined constructor for class XML_Parser in ./lib/pear/XML/Parser.php on line 227
PHP Deprecated:  Assigning the return value of new by reference is deprecated in ./lib/pear/XML/Parser.php on line 616

Which lead me to the history of these files. They were added for Spike PHP Coverage - but no longer are needed, in fact back in 2010 Petr put a deprecated.txt there:

commit db42bc5aaaa6af11b1d208a90393687280d26f26
Author: Petr Skoda <skodak@moodle.org>
Date:   Mon Jul 19 08:56:25 2010 +0000

    deprecation notice, use standard PHP libs instead

commit 695933097930bc095f3c1e22d0437139582863d3
Author: Andrew Davis <andrew@affinitysoftware.net>
Date:   Wed Nov 18 06:05:10 2009 +0000

    all MDL-20821 Removed more deprecated functions

commit 66f29dc2d17fabeeb035443edb6f5007da1e5e51
Author: stronk7 <stronk7>
Date:   Mon Jun 22 18:35:56 2009 +0000

    MDL-19579 code coverage - add PEAR/XML lib, required by Spike PHP Coverage. New BSD license.


    XML_Parser_Error

Testing Instructions

Make sure there are no results for:

git grep XML_Parser
git grep XML_PARSER_

Automated test results

None

Pre-check results

None

Workaround

None

Activity

Dan Poltawski

10 October 2014 at 19:16

Thanks for your hard work, this change is now part of Moodle 2.8-beta.

Why do we never have time to do it right, but always have time to do it over?
--anonymous

Andrew Lyons

8 October 2014 at 09:58

Looks good. Nice catch Dan!

I did some other bits of git greppage to make sure nothing had been missed - all looks good.

Passing

Sam Hemelryk

8 October 2014 at 06:39

Integrated now thanks guys.

noreply

6 October 2014 at 02:10

Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

Dan Poltawski

2 October 2014 at 23:49

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Resize issue view side panel

Fixed

Details

Priority

Minor

Assignee

Dan Poltawski

Reporter

Dan Poltawski

Peer reviewer

Tim Hunt

Integrator

Sam Hemelryk(Deactivated)

Fix versions

2.8

Tester

Andrew Lyons

Participants

Andrew Lyons

Dan Poltawski

noreply

Sam Hemelryk

Tim Hunt

Pull from Repository

Pull Main Diff URL

Pull Main Branch

MDL-47496-master

Clockify

Created 1 October 2014 at 21:13

Updated 13 October 2014 at 22:06

Resolved 10 October 2014 at 19:16

Remove unused lib/pear/XML/

Description

Testing Instructions

Automated test results

Pre-check results

Workaround

Activity

Details

Priority

Affects versions

Components

Labels

Assignee

Reporter

Peer reviewer

Integrator

Fix versions

Tester

Participants

Pull from Repository

Pull Main Diff URL

Pull Main Branch

Clockify