Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47496

Remove unused lib/pear/XML/

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8
    • Component/s: Libraries

      Description

      While doing a php lint across the codebase I noticed this:

      PHP Strict standards:  Redefining already defined constructor for class XML_Parser in ./lib/pear/XML/Parser.php on line 227
      PHP Deprecated:  Assigning the return value of new by reference is deprecated in ./lib/pear/XML/Parser.php on line 616
      

      Which lead me to the history of these files. They were added for Spike PHP Coverage - but no longer are needed, in fact back in 2010 Petr put a deprecated.txt there:

      commit db42bc5aaaa6af11b1d208a90393687280d26f26
      Author: Petr Skoda <skodak@moodle.org>
      Date:   Mon Jul 19 08:56:25 2010 +0000
       
          deprecation notice, use standard PHP libs instead
       
      commit 695933097930bc095f3c1e22d0437139582863d3
      Author: Andrew Davis <andrew@affinitysoftware.net>
      Date:   Wed Nov 18 06:05:10 2009 +0000
       
          all MDL-20821 Removed more deprecated functions
       
      commit 66f29dc2d17fabeeb035443edb6f5007da1e5e51
      Author: stronk7 <stronk7>
      Date:   Mon Jun 22 18:35:56 2009 +0000
       
          MDL-19579 code coverage - add PEAR/XML lib, required by Spike PHP Coverage. New BSD license.
       
       
          XML_Parser_Error
      

        Attachments

          Activity

            People

            Assignee:
            poltawski Dan Poltawski
            Reporter:
            poltawski Dan Poltawski
            Peer reviewer:
            Tim Hunt
            Integrator:
            Sam Hemelryk
            Tester:
            Andrew Nicols
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Nov/14