Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48156

Schedule task manager misinterprets core\plugininfo\base::is_enabled()

    XMLWordPrintable

    Details

      Description

      In the MDL-46207, we introduced a check for the plugin enabled/disabled status. Since 2.8, we do not execute tasks for disabled plugins unless the task explicitly overrides this behaviour via `get_run_if_component_disabled()` method.

      However, the world is not black and white. Many of our plugin types (most actually) do not have support for enabling/disabling individual plugins. For these, the plugininfo's `is_enabled()` returns null (as documented in that method's phpDoc).

      The trouble is that we do not execute tasks for these plugins too - we consider them all as disabled. Which is IMHO wrong. We should explicitly check for really disabled plugins.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mudrd8mz David Mudrák (@mudrd8mz)
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Peer reviewer:
              Petr Skoda
              Integrator:
              Dan Poltawski
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/14