Upgrade to phpunit 4.x

Field Tab

Scrum

Time Tracking

Field Tab

Scrum

Time Tracking

Description

Moodle is currently using quite an ancient and unsupported phpunit.

This means we cannot expect new features or bug fixes for the used release, which can create problems for test development.

Also, I found when testing with php7 that something weird happens in the phpunit error handler, resulting in "class not found" fatals - this doesn't happen with newer phpunit, so rather than working around it (probably a temporary php7 bug anyway), I figure we can 'just' upgrade phpunit as something more worthwhile.

https://moodle.atlassian.net/browse/MDL-47129#icft=MDL-47129 established that there is some deprecated assertions, in particular, calls to assertTag and assertNotTag. I have implemented one of the proposed solutions as an override function which implements the functionality Moodle needs, via some XPath queries generated in the test.

Testing Instructions

1) Run phpunit tests:
php admin/tool/phpunit/cli/init.php
vendor/bin/phpunit
2) Expect to see version 4.7.x and no test failures.

Automated test results

None

Pre-check results

None

Workaround

None

Linked work items

has been marked as being related by

MDL-51011

Get working support for PHP7 in core (all-in-one auto-generated branch)

will help resolve

MDL-47129

phpunit >= 4.2 and deprecated assertTag()

MDL-50565

Prepare Moodle for PHP7

Activity

Marina Glancy

30 October 2015 at 16:09

@tonylevi, when you add dev documentation, please insert a link next to the issue in release notes
https://docs.moodle.org/dev/Moodle_3.0_release_notes#For_developers
TIA

Eloy Lafuente

13 August 2015 at 20:11

And this is now part of Moodle, the sexy LMS that, sometimes, does things its own way. Thanks for your help taming it.

Ciao

Make definite assertions. Avoid tame, colorless, hesitating, non-committal language.
— William Strunk, Jr.

Adrian Greeve

12 August 2015 at 11:49

Once I got onto the right version, everything worked.

Test passed.

Rajesh Taneja

12 August 2015 at 11:40

As discussed with Adrian, he was using 3.7 installed phpunit.

Using composer version passes
Upgrade to 4.x installed version passes.

Sending this back for testing.

Adrian Greeve

12 August 2015 at 09:44

I'm getting the following error when running phpunit

PHP Fatal error:  Undefined class constant 'COLOR_DEFAULT' in /home/adrian/moodles/integration_master_postgres/moodle/lib/phpunit/classes/hint_resultprinter.php on line 138

Fatal error: Undefined class constant 'COLOR_DEFAULT' in /home/adrian/moodles/integration_master_postgres/moodle/lib/phpunit/classes/hint_resultprinter.php on line 138

Resize issue view side panel

Fixed

Details

Priority

Minor

Assignee

tonylevi

Reporter

tonylevi

Peer reviewer

Rajesh Taneja

Integrator

Eloy Lafuente

Fix versions

3.0

Tester

Adrian Greeve

Participants

Adam Olley

Adrian Greeve

Andrew Lyons

Eloy Lafuente

Marina Glancy

noreply

Rajesh Taneja

tonylevi

Pull from Repository

git://github.com/tlevi/moodle.git

Pull Main Diff URL

https://github.com/tlevi/moodle/compare/master...phpunit_4x

Pull Main Branch

phpunit_4x

Parent

MDL-50565 Prepare Moodle for PHP7

Clockify

Created 27 July 2015 at 13:54

Updated 30 October 2015 at 16:09

Resolved 13 August 2015 at 20:11

Upgrade to phpunit 4.x

Description

Testing Instructions

Automated test results

Pre-check results

Workaround

Linked work items

has been marked as being related by

will help resolve

Activity

Details

Priority

Affects versions

Components

Labels

Assignee

Reporter

Peer reviewer

Integrator

Fix versions

Tester

Participants

Pull from Repository

Pull Main Diff URL

Pull Main Branch

Parent

Clockify