Fixed
Details
Details
Priority
Components
Assignee
tonylevi
tonyleviReporter
tonylevi
tonyleviPeer reviewer
Rajesh Taneja
Rajesh TanejaIntegrator
Eloy Lafuente
Eloy LafuenteFix versions
Tester
Adrian Greeve
Adrian GreeveParticipants
Adam Olley
Adrian Greeve
Andrew Lyons
Eloy Lafuente
Marina Glancy
noreply
Rajesh Taneja
tonylevi
Pull from Repository
Pull Main Diff URL
Pull Main Branch
phpunit_4x
Clockify
Clockify
Created 27 July 2015 at 13:54
Updated 30 October 2015 at 16:09
Resolved 13 August 2015 at 20:11
Moodle is currently using quite an ancient and unsupported phpunit.
This means we cannot expect new features or bug fixes for the used release, which can create problems for test development.
Also, I found when testing with php7 that something weird happens in the phpunit error handler, resulting in "class not found" fatals - this doesn't happen with newer phpunit, so rather than working around it (probably a temporary php7 bug anyway), I figure we can 'just' upgrade phpunit as something more worthwhile.
https://moodle.atlassian.net/browse/MDL-47129#icft=MDL-47129 established that there is some deprecated assertions, in particular, calls to assertTag and assertNotTag. I have implemented one of the proposed solutions as an override function which implements the functionality Moodle needs, via some XPath queries generated in the test.