Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52013

Allow mod_assign plugins to add calendar events

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.8.8, 2.9.2
    • 3.1
    • Assignment
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MOODLE_31_STABLE
    • Hide

      To test the patch:

      1. Hack a submission plugin to add / update a calendar event for the assignment (with a different eventtype than 'due') in the save_settings() method
      2. Create an assignment with a due date. Confirm that both this and the other event have been added to the calendar as expected.
      3. Edit the assignment to disable the due date. Confirm that the other event has not been removed.
      4. Hide the assignment. Confirm that the other event is hidden in the calendar
      5. Delete the assignment. Confirm that the other event is deleted.

      Also run the mod_assign unit tests and confirm they still pass.

      Show
      To test the patch: Hack a submission plugin to add / update a calendar event for the assignment (with a different eventtype than 'due') in the save_settings() method Create an assignment with a due date. Confirm that both this and the other event have been added to the calendar as expected. Edit the assignment to disable the due date. Confirm that the other event has not been removed. Hide the assignment. Confirm that the other event is hidden in the calendar Delete the assignment. Confirm that the other event is deleted. Also run the mod_assign unit tests and confirm they still pass.

    Description

      Submission and feedback plugins are able to add assignment events to the Moodle calendar, and the events are hidden / deleted as expected, but there are a couple of non-intuitive consequences:

      • a debug message is emitted when assign::update_calendar() is called
      • the event is deleted if the assignment due date is removed

      It would be useful if these side-effects could be removed so that subplugins are able to add calendar events if they want to.

      Attachments

        Activity

          People

            maherne Michael Aherne
            maherne Michael Aherne
            John Okely John Okely
            Dan Poltawski Dan Poltawski
            Simey Lameze Simey Lameze
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              23/May/16