Delete Zend framework

Description

Final step for this epic.

Testing Instructions

Before applying the patch

We need to do these steps before applying the patch so we cab compare the output.

  1. Enable networking ("Site administration" > "Advanced features").

  2. Browse to "Site administration" > "Networking" > "XML-RPC hosts".

  3. Add 192.168.0.0/0 and save.

  4. Browse to "Site administration" > "Networking" > "Peers" > "All hosts".

  5. Click the "Services" tab.

  6. Check "Publish" on every service then save.

  7. Apply the attached patch (it disables xml encryption).

  8. Run this from a terminal:

    curl 'http://your_moodle/mnet/xmlrpc/server.php' -H "Content-Type: text/xml" --data "<?xml version='1.0' encoding='UTF-8'?><methodCall><methodName>system/listMethods</methodName><params> </params></methodCall>"

  9. Take note of the output.

  10. Run this from a terminal:

    curl 'http://your_moodle.mithrandir/mnet/xmlrpc/server.php' -H "Content-Type: text/xml" --data "<?xml version='1.0' encoding='UTF-8'?><methodCall><methodName>system/methodSignature</methodName><params><param><value><string>auth/mnet/auth.php/fetch_theme_info</string></value></param></params></methodCall>

  11. Take note of the output.

  12. Rerun the previous command, replacing auth/mnet/auth.php/fetch_theme_info with another random method (the first command we ran gave a list of methods you can use. Take note of the output and do it for a few more random methods.

After the patch

  1. Install moodle, verify there are no errors.

  2. Follow the testing instructions from the blocking issues, make sure there are no errors that mention Zend.

  3. Follow the same instructions as in the "Before applying the patch" section, but make sure to use the same methods for steps 10-12.

  4. Ensure the output is the same. NB: A few methods will have different output. These are auth/mnet/auth.php/fetch_user_image, enrol/mnet/enrol.php/enrol_user, enrol/mnet/enrol.php/course_enrolments

Automated test results

None

Pre-check results

None

Workaround

None

Attachments

1

Activity

Cameron Ball
18 May 2016 at 12:31

Is it needed to document this anywhere other than on the release notes page? Afaik the only change due to this that could potentially affects someone is due to https://moodle.atlassian.net/browse/MDL-53962#icft=MDL-53962

We always told people not to use Zend for their own stuff.

Eloy Lafuente (stronk7)
24 March 2016 at 23:11

And these delicious changes are now part of upstream Moodle, yay! Many, many thanks!

There are two ways of constructing a software design: One way is
to make it so simple that there are obviously no deficiencies, and the other way is
to make it so complicated that there are no obvious deficiencies.
The first method is far more difficult.
– Tony Hoare

Jun
23 March 2016 at 15:13

Thanks for working on this Cam,

Works as described.

It's a little strange since you mentioned in the testing instructions that some of the output will be different. But in my local environment, the XML output for all of the listed mnet methods are the same before and after the patch. Though I don't really see any problem with it, so I'll be passing this.

Tested on master. Passed!

David Monllaó
21 March 2016 at 11:56

Thanks Cameron, integrated to master.

Noting here that we removed the opcache hack we had that made it include comments as we do not need reflection now.

David Monllaó
21 March 2016 at 10:45
Fixed

Details

Priority

Affects versions

Components

Labels

Assignee

Reporter

Peer reviewer

Integrator

Fix versions

Tester

Participants

Cameron Ball
Dan Poltawski
David Monllaó
David Mudrak
Eloy Lafuente (stronk7)
Jun
Moodle HQ
noreply

Pull from Repository

Pull Main Diff URL

Pull Main Branch

Parent

Clockify

Created 19 November 2015 at 02:17
Updated 11 May 2017 at 16:46
Resolved 24 March 2016 at 23:11