Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53207

Display stock avatar instead of own user picture from messages from fake users

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.4, 3.0
    • Fix Version/s: 3.1
    • Component/s: Messages
    • Testing Instructions:
      Hide
      Set up:
      1. Set up 3 user accounts s1, s2 and s3 with distinct profile pictures.
      2. Create a course.
      3. Enrol s1, s2 and s3 to the course.
      4. Login as s2 and send a message "from s2" to s1.
      5. Login as s3 and send a message "from s3" to s1.
      6. Login as s1 and send a message "to s2" to s2.
      7. Login as s1 and send a message "to s3" to s3.
      8. Change s2's user ID to the noreplyuser (-10) in mdl_user table.
      9. Delete s3 from the mdl_user table.
      10. Login as s1.
      11. From the user menu, choose 'Messages'
      12. Click Advanced (on the right next to the "Search people and messages" button)
      13. Click on "All messages to me or from me" radio button to cover all messages.
      14. Enter "s" in the Keywords field and click Search messages
      15. Check the list of messages.
      Case 1: Message from no-reply user (s2)
      1. Check the From field for the message "from s2".
        • Confirm that the message received from the no-reply user shows the stock profile picture with no link to the profile, and no name.
      Case 2: Message to no-reply user (s2)
      1. Check the To field for the message "to s2".
        • Confirm that the message sent to the no-reply user shows the stock profile picture with no link to the profile, and no name.
      Case 3: Message from deleted user (s3)
      1. Check the From field for the message "from s3".
        • Confirm that the message received from the deleted user shows the stock profile picture with no link to the profile, and no name.
      Case 4: Message to deleted user (s3)
      1. Check the To field for the message "to s3".
        • Confirm that the message sent to the deleted user shows the stock profile picture with no link to the profile, and no name.
      Show
      Set up: Set up 3 user accounts s1, s2 and s3 with distinct profile pictures. Create a course. Enrol s1, s2 and s3 to the course. Login as s2 and send a message "from s2" to s1. Login as s3 and send a message "from s3" to s1. Login as s1 and send a message "to s2" to s2. Login as s1 and send a message "to s3" to s3. Change s2's user ID to the noreplyuser (-10) in mdl_user table. Delete s3 from the mdl_user table. Login as s1. From the user menu, choose 'Messages' Click Advanced (on the right next to the "Search people and messages" button) Click on "All messages to me or from me" radio button to cover all messages. Enter "s" in the Keywords field and click Search messages Check the list of messages. Case 1: Message from no-reply user (s2) Check the From field for the message "from s2". Confirm that the message received from the no-reply user shows the stock profile picture with no link to the profile, and no name. Case 2: Message to no-reply user (s2) Check the To field for the message "to s2". Confirm that the message sent to the no-reply user shows the stock profile picture with no link to the profile, and no name. Case 3: Message from deleted user (s3) Check the From field for the message "from s3". Confirm that the message received from the deleted user shows the stock profile picture with no link to the profile, and no name. Case 4: Message to deleted user (s3) Check the To field for the message "to s3". Confirm that the message sent to the deleted user shows the stock profile picture with no link to the profile, and no name.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Reproduction
      1. Set a profile image for yourself
      2. Send some messages to a user, then modify the DB to change the useridto to the noreplyuser (-10).
      3. From the user menu, choose 'Messages'
      4. Click Advanced (on the right next to the "Search people and messages" button)
      5. Search for something within the message (e.g. a space or single letter)
      Expected result

      The message from the no reply user should show the stock head and shoulders image with no link to the profile, and no name.

      Actual result

      Your own profile image and name is shown with a link to your own profile.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16