Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54617

Always show count of online users

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.4
    • Fix Version/s: 3.2
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide
      • Log in new moodle install
      • Add the "Online users" block to the frontpage (the site home page, not your dashboard)
      • See that you are the only user online and there is a ": 1" on the block header (after the "Online users (in last X minutes)")
      • Log in with more than 50 users and make sure the number of users are correctly displayed (an easier way is to modify the user table and set lastaccess time to the current time)
      Show
      Log in new moodle install Add the "Online users" block to the frontpage (the site home page, not your dashboard) See that you are the only user online and there is a ": 1" on the block header (after the "Online users (in last X minutes)") Log in with more than 50 users and make sure the number of users are correctly displayed (an easier way is to modify the user table and set lastaccess time to the current time)
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-54617-master

      Description

      On the online users block there is a hardcoded limit of 50 users to show and this same limit is used to also define if the number of online users will be shown or not.
      There can be a (performance) reason for not showing more than 50 users, but this do not holds true for the count of online users.
      It seems to be better to always show how many users there are online, may it be 0 or 1 million.

      This issue solves this also removing an "if" (less code is better code).

        Attachments

          Activity

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16