String API - moodledata folder - typo3temp - new files use wrong permissions

Field Tab

Scrum

Time Tracking

Field Tab

Scrum

Time Tracking

Description

Just seen in /lib/classes/text.php:

// Default mask for Typo
$GLOBALS['TYPO3_CONF_VARS']['BE']['fileCreateMask'] = $CFG->directorypermissions;

Should it not rather use $CFG->filepermissions?

The files created in this class seem to be set using wrong permissions.
/moodledata/temp/typo3temp/cs/cscase_utf-8.tbl
/moodledata/temp/typo3temp/cs/csascii_utf-8.tbl

A script of mine checks permissions inside the moodledata folder (always be readable and writable by the apache user), so I found out about those two.

Testing Instructions

Open the Moodle tempdir and find the typo3temp/cs/ folder within it
Delete all files in it
Run the attached test.php
View the long list of the files in the directory and check permissions
1. Ensure that they match those found in the moodle filedir

Automated test results

None

Pre-check results

None

Workaround

None

Attachments

test.php

28 Mar, 2017

Activity

noreply

7 April 2017 at 15:03

Thanks for your contributions! This change is now available from the main moodle.git repository and will shortly be available on download.moodle.org.

Closing as fixed!

Simey Lameze

5 April 2017 at 10:51

Thanks Andrew, works as expected. Passing

Eloy Lafuente

5 April 2017 at 01:27

Integrated (31, 32 & master), thanks!

noreply

3 April 2017 at 03:05

Fails against automated checks.

Checked https://moodle.atlassian.net/browse/MDL-55326#icft=MDL-55326 using repository: git://github.com/andrewnicols/moodle.git

MOODLE_31_STABLE (1 errors / 0 warnings) [branch: MDL-55326-31 | CI Job]
- phplint (0/0), phpcs (1/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), grunt (0/0), shifter (0/0), travis (0/0), mustache (0/0),
MOODLE_32_STABLE (1 errors / 0 warnings) [branch: MDL-55326-32 | CI Job]
- phplint (0/0), phpcs (1/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), grunt (0/0), shifter (0/0), travis (0/0), mustache (0/0),
master (1 errors / 0 warnings) [branch: MDL-55326-master | CI Job]
- phplint (0/0), phpcs (1/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), grunt (0/0), shifter (0/0), travis (0/0), mustache (0/0),

Should these errors be fixed?

noreply

3 April 2017 at 02:24

Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

Resize issue view side panel

Fixed

Details

Priority

Minor

Assignee

Andrew Lyons

Reporter

Daniel Poggenpohl

Peer reviewer

Jake Dallimore

Integrator

Eloy Lafuente

Fix versions

3.1.6

3.2.3

Tester

Simey Lameze

Participants

Aaron St Clair

Andrew Lyons

Daniel Poggenpohl

Eloy Lafuente

Guido Hornig

Jake Dallimore

Marina Glancy

noreply

Show all 9 people

Pull from Repository

git://github.com/andrewnicols/moodle.git

Pull Main Diff URL

https://github.com/andrewnicols/moodle/compare/216ea39be7...MDL-55326-master

Pull Main Branch

MDL-55326-master

Difficulty

Easy

Clockify

Created 25 July 2016 at 17:18

Updated 7 April 2017 at 15:03

Resolved 7 April 2017 at 15:03

String API - moodledata folder - typo3temp - new files use wrong permissions

Description

Testing Instructions

Automated test results

Pre-check results

Workaround

Attachments

Activity

Details

Priority

Affects versions

Components

Labels

Assignee

Reporter

Peer reviewer

Integrator

Fix versions

Tester

Participants

Pull from Repository

Pull Main Diff URL

Pull Main Branch

Difficulty

Clockify