[MDL-64684] jQuery/requirejs should not be minified when cachejs is disabled - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7
Fix Version/s: 3.7
Component/s: JavaScript
Labels:
- ci
- release_notes

Affected Branches:
MOODLE_37_STABLE
Fixed Branches:
MOODLE_37_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-64684~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/c092f75791...MDL-64684-master
Testing Instructions:
Hide

Open up browser dev tools

Open the Network tab

Ensure that $CFG->cachejs is set to true

Open any page in Moodle

Find the jquery-3.2.1 file in the Network tab (filter by JS files only, or just search)

Confirm that the filename includes .min.js

Confirm that the content is minified, and is difficult to read

Find the requirejs file in the Network tab (filter by JS files only, or just search)

Confirm that the filename includes .min.js

Confirm that the content is minified, and is difficult to read (you can check the content by clicking the filename, then opening the Response tab for the fille)

Update $CFG->cachejs and set it to false

Refresh the page

Find the jquery-3.2.1 file in the Network tab (filter by JS files only, or just search)

Confirm that the filename does not include .min.js

Confirm that the filename does not include .js

Confirm that the content is not minified, and is readable

Find the requirejs file in the Network tab (filter by JS files only, or just search)

Confirm that the filename does not include .min.js

Confirm that the filename does not include .js

Confirm that the content is not minified, and is readable
Show
Open up browser dev tools Open the Network tab Ensure that $CFG->cachejs is set to true Open any page in Moodle Find the jquery-3.2.1 file in the Network tab (filter by JS files only, or just search) Confirm that the filename includes .min.js Confirm that the content is minified, and is difficult to read Find the requirejs file in the Network tab (filter by JS files only, or just search) Confirm that the filename includes .min.js Confirm that the content is minified, and is difficult to read (you can check the content by clicking the filename, then opening the Response tab for the fille) Update $CFG->cachejs and set it to false Refresh the page Find the jquery-3.2.1 file in the Network tab (filter by JS files only, or just search) Confirm that the filename does not include .min.js Confirm that the filename does not include .js Confirm that the content is not minified, and is readable Find the requirejs file in the Network tab (filter by JS files only, or just search) Confirm that the filename does not include .min.js Confirm that the filename does not include .js Confirm that the content is not minified, and is readable

Description

Right now if I need to debug my JS I set cachejs to 0. This stops minification and caching of those files. Great!

But... jQuery and requireJS are still minified, which can make debugging rather tricky.

This issue seeks to stop minifying jquery, jquery-ui, and requirejs when cachejs is disabled, inline with everything else.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-64684.jpg
48 kB
13/Feb/19 2:19 PM

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Michael Hawkins

Integrator:: Jun Pataleta

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, Jack Eapen, Jun Pataleta, Michael Hawkins

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 24/Jan/19 9:01 AM

Updated:: 10/Jul/20 8:36 AM

Resolved:: 15/Feb/19 9:47 AM

Fix Release Date:: 20/May/19

Time Tracking

Estimated:

Remaining:

Logged:

20m