Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64773

Allow conversations to be muted/unmuted

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Prerequisites.
      1. A site with multiple users.
      2. Site-wide messaging enabled ('messagingallusers' is the setting name).
      3. Create a course.
      4. Enrol multiple users.
      5. Create a group with 'Group messaging' to 'Yes'.
      6. Assign all the users you enrolled into that group.
      7. Log in as one of the users in the group.
      8. In the messaging UI search for another user.
      9. Send them a message.
      10. Search for another user.
      11. Send them a message.
      12. View one of the conversations in 'Private' and click on the '...' on the top-right.
      13. Select 'Star'.
      Test 1

      Ensure you are using the Boost theme

      1. View the starred conversation.
      2. Click on '...' in the top right.
      3. Click 'Mute'.
      4. Confirm an icon appears next to the user's name
      5. View the group conversation.
      6. Click on '...' in the top right.
      7. Click 'Mute'.
      8. Confirm an icon appears next to the conversation's name
      9. View the private conversation.
      10. Click on '...' in the top right.
      11. Click 'Mute'.
      12. Confirm an icon appears next to the user's name
      13. Click to go back to the page that lists all conversations in the messaging UI.
      14. Confirm the 3 conversations have those icons next to their name.
      15. Refresh the page.
      16. Open the messaging drawer.
      17. Confirm the 3 conversations have those icons next to their name.
      18. Confirm the 3 conversations still have those icons next to their name when you view them individually.
      19. View the starred conversation.
      20. Click on '...' in the top right.
      21. Click 'Unmute'.
      22. Confirm an icon disappears next to the user's name
      23. View the group conversation.
      24. Click on '...' in the top right.
      25. Click 'Unmute'.
      26. Confirm an icon disappears next to the conversation's name
      27. View the private conversation.
      28. Click on '...' in the top right.
      29. Click 'Unmute'.
      30. Confirm an icon disappears next to the user's name
      31. Click to go back to the page that lists all conversations in the messaging UI.
      32. Confirm the 3 conversations do not have those icons next to their name.
      33. Refresh the page.
      34. Open the messaging drawer.
      35. Confirm the 3 conversations do not have those icons next to their name in the overview page.
      36. Confirm the 3 conversations do not have those icons next to their name when you view them individually.
      Test 2
      1. Repeat Test 1 but using the Clean theme.
      Test 3
      1. Set-up mailcatcher (https://mailcatcher.me/).
      2. Log in as an admin.
      3. Visit ‘Site administration’ > ‘Server’ > ‘Outgoing mail configuration’.
      4. Set the 'SMTP hosts' field to '127.0.0.1:1025' and save.
      5. In your config.php file add $CFG->block_online_users_timetosee = 1;
      6. Visit http://127.0.0.1:1080/ in your browser so you can view outgoing emails.
      7. Log in as the admin.
      8. In another browser log in as another user.
      9. Send the admin a message.
      10. Check MailCatcher and confirm an email was sent.
      11. As the admin use the messaging UI to mute the user.
      12. Send the admin another message.
      13. Check MailCatcher and confirm there was not an email sent.
      Show
      Prerequisites. A site with multiple users. Site-wide messaging enabled ('messagingallusers' is the setting name). Create a course. Enrol multiple users. Create a group with 'Group messaging' to 'Yes'. Assign all the users you enrolled into that group. Log in as one of the users in the group. In the messaging UI search for another user. Send them a message. Search for another user. Send them a message. View one of the conversations in 'Private' and click on the '...' on the top-right. Select 'Star'. Test 1 Ensure you are using the Boost theme View the starred conversation. Click on '...' in the top right. Click 'Mute'. Confirm an icon appears next to the user's name View the group conversation. Click on '...' in the top right. Click 'Mute'. Confirm an icon appears next to the conversation's name View the private conversation. Click on '...' in the top right. Click 'Mute'. Confirm an icon appears next to the user's name Click to go back to the page that lists all conversations in the messaging UI. Confirm the 3 conversations have those icons next to their name. Refresh the page. Open the messaging drawer. Confirm the 3 conversations have those icons next to their name. Confirm the 3 conversations still have those icons next to their name when you view them individually. View the starred conversation. Click on '...' in the top right. Click 'Unmute'. Confirm an icon disappears next to the user's name View the group conversation. Click on '...' in the top right. Click 'Unmute'. Confirm an icon disappears next to the conversation's name View the private conversation. Click on '...' in the top right. Click 'Unmute'. Confirm an icon disappears next to the user's name Click to go back to the page that lists all conversations in the messaging UI. Confirm the 3 conversations do not have those icons next to their name. Refresh the page. Open the messaging drawer. Confirm the 3 conversations do not have those icons next to their name in the overview page. Confirm the 3 conversations do not have those icons next to their name when you view them individually. Test 2 Repeat Test 1 but using the Clean theme. Test 3 Set-up mailcatcher ( https://mailcatcher.me/ ). Log in as an admin. Visit ‘Site administration’ > ‘Server’ > ‘Outgoing mail configuration’. Set the 'SMTP hosts' field to '127.0.0.1:1025' and save. In your config.php file add $CFG->block_online_users_timetosee = 1; Visit http://127.0.0.1:1080/ in your browser so you can view outgoing emails. Log in as the admin. In another browser log in as another user. Send the admin a message. Check MailCatcher and confirm an email was sent. As the admin use the messaging UI to mute the user. Send the admin another message. Check MailCatcher and confirm there was not an email sent.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64773_master

      Description

      This would allow users to mute busy conversations they may not want to be notified of.

      There is still the hack in core if ($conv->type == \core_message\api::MESSAGE_CONVERSATION_TYPE_INDIVIDUAL) { in lib/classes/message/manager.php that will prevent notifications for group messages, this will be dealt with in MDL-64017.

        Attachments

        1. 1.png
          1.png
          155 kB
        2. 2.png
          2.png
          201 kB
        3. 3.png
          3.png
          87 kB
        4. muted.png
          muted.png
          0.2 kB
        5. muted.svg
          0.5 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 10 minutes
                  1h 10m