-
Improvement
-
Resolution: Fixed
-
Minor
-
3.8
-
MOODLE_38_STABLE
-
MOODLE_38_STABLE
-
If you implement xsendfile in an alternative_file_system_class then this only works if you have set up xsendfile for local files. There are legitimate use cases where the files served by the alternative_file_system_class could be served through that file stores xsendfile method, and the other non file api files such as the theme / js files might be either not served through xsendfile, or served via a different xsendfile method.
So proposing:
1) The $CFG->xsendfile remains but by default ONLY applies directly to local non File API files:
$CFG->xsendfile = 'foobar'
2) The file_system_class implements a new method which is whether it supports xsendfile (ie is configured and working, not just code support)
3) All the code paths that serve files honor either only $CFG->xsendfile for local files, or defer to the store method for File API files
4) The default file store implements this as returns true if $CFG->xsendfile is set
- has a non-specific relationship to
-
MDL-66493 readstring_accel should not use xsendfile via get_file_storage()
-
- Closed
-