Bigbluebutton Behat test should follow the Given/When/Then types of scenario

Testing Instructions

Covered by behat tests

Automated test results

None

Pre-check results

None

Workaround

None

has to be finished together with

Activity

noreply
13 March 2024 at 01:02

Thanks for your contributions! This change is now available from the main moodle.git repository and will shortly be available on download.moodle.org.

Closing as fixed!

Ilya Tregubov
13 March 2024 at 00:10

Passing on behalf of CiBoT

Huong Nguyen
12 March 2024 at 03:33

Thanks, Shamiso and Simey for working on this issue.

It has now been integrated \o/
Integrated to main, 4.3, 4.2 and 4.1.
Over to testing.

 

Simey Lameze
12 March 2024 at 03:21

Hi thanks for working on this. Overall I think this is a good improvement to BBB behat coverage and the tests are looking much better with only one Given/When/Then per scenario. I noticed some scenarios where there are no Given keyword, but that's because in that case the test is short and the Given is in the Background section so there's no need for it.

Since this is a testing related issue I have backported the patch to all supported versions including 4.1. I have fixed some conflicts on 4.2 and launched CI builds, which all passed

Happy to get this merged into core now.

Cheers,

Simey

noreply
11 March 2024 at 13:41

This issue has been sent to integration after the freeze.

If you want Moodle HQ to consider including it into the incoming major release please add the "unhold_requested" label, and post a comment here outlining good reasons why you think it should be considered for late integration into the next major release.

Fixed

Details

Priority

Affects versions

Components

Labels

Assignee

Reporter

Peer reviewer

Integrator

Fix versions

Tester

Participants

Angelia Dela Cruz
Huong Nguyen
Ilya Tregubov
Jun
Laurent David
noreply
Shamiso Jaravaza
Simey Lameze

Pull from Repository

Pull Main Diff URL

Pull Main Branch

Component Lead Review

Pull 4.3 Diff URL

Pull 4.3 Branch

Pull 4.1 Diff URL

Pull 4.1 Branch

Clockify

Created 5 January 2023 at 15:45
Updated 13 March 2024 at 01:02
Resolved 13 March 2024 at 01:02