Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78993

Remove the $CFG->svgicons setting

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-78993-master
    • Hide

      Covered by PHPUnit tests.

       

      For manual tests, you can:

      1. Download bookmark-new.svg and copy it to pix/b/ (if it doesn't exist).
      2. Run grunt componentlibrary
      3. Login as admin.
      4. Go to Site administration > Development > UI Component library
      5. Search for the icons page and load it (admin/tool/componentlibrary/docspage.php/moodle/components/moodle-icons)
      6. Search for the bookmark-new icon and check that it looks like the attached bookmark-new.svg (instead of like pix/b/bookmark-new.png)
      Show
      Covered by PHPUnit tests.   For manual tests, you can: Download bookmark-new.svg and copy it to pix/b/ (if it doesn't exist). Run grunt componentlibrary Login as admin. Go to Site administration > Development > UI Component library Search for the icons page and load it ( admin/tool/componentlibrary/docspage.php/moodle/components/moodle-icons ) Search for the bookmark-new icon and check that it looks like the attached bookmark-new.svg (instead of like pix/b/bookmark-new.png )
    • 1
    • HQ 2023 Sprint I3.1 Moppies

      While addressing MDL-67271, I came across the $CFG->svgicons parameter introduced in Moodle 2.4 through MDL-22955. This setting was necessary then due to incomplete SVG support in certain web browsers.

      However, the landscape has evolved significantly since then, and all modern browsers now handle SVG files correctly, as confirmed by this compatibility chart: https://caniuse.com/svg. Consequently, it might be prudent to consider deprecating this configuration setting.

            sarjona Sara Arjona (@sarjona)
            sarjona Sara Arjona (@sarjona)
            Laurent David Laurent David
            Amaia Anabitarte Amaia Anabitarte
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 40 minutes
                3h 40m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.