Double encoding of question bank categories in the category management drop marker
Description
Testing Instructions
Covered by Behat tests.
In a course, in the question bank, create several categories and name one Category & < > " ' &amp;. The already-escaped & is intentional.
Verify the category is displayed as Category & < > " ' &amp;.
Drag a category over Category & < > " ' &amp; to reveal the new child drop target [ + ].
Drag the category to the new child drop target and hold it there.
Verify the tooltip text "As a new child of Category & < > " ' &amp; " is correct.
Automated test results
Launching automatic jobs for branch MDL-82895-405
https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17727/ PHPUnit (sqlsrv)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60378/ Behat (NonJS - boost and classic)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60379/ Behat (Firefox - boost)
Launching automatic jobs for branch MDL-82895-main
https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17728/ PHPUnit (sqlsrv)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60380/ Behat (NonJS - boost and classic)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60381/ Behat (Firefox - boost)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60382/ Behat (Firefox - classic)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60383/ App tests (stable app version)
Built on: Mon Dec 16 12:25:22 PM UTC 2024
Pre-check results
Code verified against automated checks with warnings.
Checked MDL-82895 using repository: https://github.com/lucaboesch/moodle.git
MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-82895-405 | CI Job]
main (0 errors / 1 warnings) [branch: MDL-82895-main | CI Job]
Built on: Mon Dec 16 11:57:19 AM UTC 2024
Workaround
Attachments
has been marked as being related by
Activity
Thanks for your contributions! This change is now available from the main moodle.git repository and will shortly be available on download.moodle.org.
Closing as fixed!
The issue has been successfully tested and fixed in versions 4.5, and Main. Thank you!
2.
5.
Thanks, Luca for working on this issue.
It has now been integrated \o/
Integrated to main and 4.5 only.
Over to testing.
Thanks @Luca Bösch. I think this is finally ready to go forwards
Follow the checks as defined in Moodle's peer review documentation
[y] Syntax
[y] Output
[-] Component library
[-] Icons
[y] Language
[y] Accessibility
[-] Databases
[-] Performance and Clustering
[y] Security
[-] Privacy (see Privacy API)
[-] The Moodle mobile app / web services
[-] Third party code
[y] Documentation
[y] Git
[y] Testing (instructions and automated tests)
[y] Overall completeness and correctness
The main moodle.git repository has just been updated with the latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao
Details
Details
Priority
MinorAffects versions
Components
Assignee
Reporter
Peer reviewer
Integrator
Fix versions
Tester
Participants
Pull from Repository
Pull Main Diff URL
Pull Main Branch
Pull 4.5 Diff URL
Pull 4.5 Branch
Component Lead Review
Clockify
Start / Stop
Clockify
Question bank categories with & < > " ' in their name do not get a correct drag and drop hover text in question bank category management.
TO REPRODUCE:
In https://qa.moodledemo.net/question/bank/managecategories/category.php?courseid=2 try to drag another question category into "Default for P&C Council" category so that it would create a new child category.
WHAT YOU EXPECT: The hover text is correct.
WHAT ACTUALLY HAPPENS: The hover text is double encoded.