Toggling activity done doesn't update the course index

Field Tab

Scrum

Time Tracking

Field Tab

Scrum

Time Tracking

Description

In a course section where an activity which has previously (before this page load) been manually marked as done, click to mark it as not done.

Expected:

The course index toggles the activity as not done.

Actual:

Course index is not updated.

Note:

Activities which are not marked as done on page load can be toggled as expected.

Testing Instructions

Tested using behat.

Automated test results

Launching automatic jobs for branch MDL-84243-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18105/ PHPUnit (sqlsrv)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61849/ Behat (NonJS - boost and classic)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61850/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-84243-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18106/ PHPUnit (sqlsrv)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61851/ Behat (NonJS - boost and classic)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61852/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-84243-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18107/ PHPUnit (sqlsrv)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61853/ Behat (NonJS - boost and classic)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61854/ Behat (Firefox - boost)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61855/ Behat (Firefox - classic)
https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61856/ App tests (stable app version)

Built on: Wed Jan 29 08:30:22 AM UTC 2025

Pre-check results

Code verified against automated checks.

Checked MDL-84243 using repository: https://github.com/ferranrecio/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84243-404 | CI Job]
MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84243-405 | CI Job]
main (0 errors / 0 warnings) [branch: MDL-84243-main | CI Job]

_{More information about this report}

Built on: Wed Jan 29 08:34:53 AM UTC 2025

Workaround

None

Attachments

image-2025-01-20-07-44-22-466.png

20 Jan, 2025

Linked work items

Activity

noreply

31 January 2025 at 02:47

Thanks for your contributions! This change is now available from the main moodle.git repository and will shortly be available on download.moodle.org.

Closing as fixed!

noreply

30 January 2025 at 15:54

Testing passed after 24h without any problem reported, yay!

Sara Arjona

29 January 2025 at 15:48

Hi Ferran,

Thank you for working on this issue

It has now been integrated to 4.4, 4.5 and main \o/
Over to testing.

Amaia Anabitarte

29 January 2025 at 14:53

Thanks Ferran for working on this issue!

I've seen the 'Edit a course tool' behat test has failed for one of the runs, but I don't think this fail is related to the patch, and the patch seems fine to me, so I'm OK to push this forward.

Thanks for your work and help.

Amaia

Laurent David

29 January 2025 at 06:38

Hi @Ferran Recio Calderó,

Thanks for the patch. It works as expected.

I added tested using behat as CI was complaining about test instruction missing.

Follow the checks as defined in Moodle's peer review documentation

[ ] Syntax
[ ] Output
[-] Component library
[-] Icons
[-] Language
[-] Accessibility
[-] Databases
[-] Performance and Clustering
[-] Security
[-] Privacy (see Privacy API)
[-] The Moodle mobile app / web services
[-] Third party code
[-] Documentation
[ ] Git
[ ] Testing (instructions and automated tests)
[ ] Overall completeness and correctness

Resize issue view side panel

Fixed

Details

Priority

Minor

Affects versions

4.5

Components

Course

Labels

triagedhqteam_moppiesrelease_notesci

Assignee

Ferran Recio Calderó

Reporter

Stuart Lamour

Peer reviewer

Laurent David

Integrator

Amaia Anabitarte

Fix versions

4.4.6

4.5.2

Tester

noreply

Participants

Amaia Anabitarte

Ferran Recio Calderó

Kim Jared Lucas

Laurent David

Leon Stringer

noreply

Sara Arjona

Stuart Lamour

Pull from Repository

https://github.com/ferranrecio/moodle.git

Pull Main Diff URL

https://github.com/ferranrecio/moodle/compare/bcf06a0484...MDL-84243-main?w=1

Pull Main Branch

MDL-84243-main

Component Lead Review

Yes

Pull 4.5 Diff URL

https://github.com/ferranrecio/moodle/compare/77692ee5ea...MDL-84243-405?w=1

Pull 4.5 Branch

MDL-84243-405

Pull 4.4 Diff URL

https://github.com/ferranrecio/moodle/compare/c5d94d21f2...MDL-84243-404?w=1

Pull 4.4 Branch

MDL-84243-404

Clockify

Created 17 January 2025 at 16:01

Updated 3 February 2025 at 10:54

Resolved 31 January 2025 at 02:47

Toggling activity done doesn't update the course index

Description

Testing Instructions

Automated test results

Pre-check results

Workaround

Attachments

Linked work items

Testing discovered

duplicates

has been marked as being related by

is a regression caused by

Activity

Details

Priority

Affects versions

Components

Labels

Assignee

Reporter

Peer reviewer

Integrator

Fix versions

Tester

Participants

Pull from Repository

Pull Main Diff URL

Pull Main Branch

Component Lead Review

Pull 4.5 Diff URL

Pull 4.5 Branch

Pull 4.4 Diff URL

Pull 4.4 Branch

Clockify