Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66537

Annotate PDF - Right-to-left UI - The rotate buttons order is confusing

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites:

      # A course with a student enrolled

      1. An assignment in the course with annotation enabled as a feedback method
      2. An RTL language pack installed(Follow instructions here)

      Testing:

      1. Login as a teacher
      2. Go to the assignment within the course
      3. Go to the grading table.
      4. Select the 'Grade' button against the student (Open in a new tab - Tab2)
        1. Confirm that the button order is "Rotate left; Rotate right":
      5. In Tab1, Switch to the RTL language
      6. Refresh Tab2 and confirm the rotate left / right buttons' position appear unchanged. Refer    for expected behaviour
        1. Confirm that the button order is NOT "Rotate right; Rotate left":
      Show
      Prerequisites: # A course with a student enrolled An assignment in the course with annotation enabled as a feedback method An RTL language pack installed(Follow instructions here ) Testing: Login as a teacher Go to the assignment within the course Go to the grading table. Select the 'Grade' button against the student (Open in a new tab - Tab2) Confirm that the button order is "Rotate left; Rotate right" : In Tab1, Switch to the RTL language Refresh Tab2 and confirm the rotate left / right buttons' position appear unchanged. Refer    for expected behaviour Confirm that the button order is NOT "Rotate right; Rotate left" :
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-66537-master

      Description

      Please note that this bug relates only to Right-to-left UI environments.

       

      Repro Steps

      1. Login to the Moodle environment
      2. Switch to the English UI.
      3. Login as a teacher and create an assignment.
      4. Login as a student and submit a document.
      5. Login again as a teacher, enter the assignment and the submissions table,  and click the "Grade"button at the row of the student that submitted the document.
      6. Play a little bit with the rotate buttons to see what each one does, in case the icons are not clear enough  

       

      Actual Results

      The "Rotate 90 degrees to the right" button is the left one, and the "Rotate 90 degrees to the left" button is the right one.

      While still usable, this is counter-intuitive and confusing.

       

      Expected Results

      The "Rotate 90 degrees to the right" button should be the right one, and the "Rotate 90 degrees to the left" button should be the left one.

      Right-to-left (RTL) UI shouldn't always be an exact mirror of the Left-to-right UI, and this is a good example for that. 

        Attachments

        1. 66537-a.png
          66537-a.png
          2.02 MB
        2. 66537-b.png
          66537-b.png
          2.02 MB
        3. Annotate PDF - Toolbar buttons - RTL vs LTR modes.png
          Annotate PDF - Toolbar buttons - RTL vs LTR modes.png
          54 kB
        4. button-order-ltr.png
          button-order-ltr.png
          7 kB
        5. button-order-rtl.png
          button-order-rtl.png
          10 kB
        6. image-2019-09-11-09-57-39-079.png
          image-2019-09-11-09-57-39-079.png
          280 kB
        7. Screenshot from 2019-08-30 13-08-54.png
          Screenshot from 2019-08-30 13-08-54.png
          24 kB

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 10 minutes
                2h 10m