[MDL-64348] Improve ajax template fetching - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.6.1, 3.7
Fix Version/s: 3.7
Component/s: JavaScript, Performance, Themes
Labels:

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_37_STABLE
Pull from Repository:
git://github.com/ryanwyllie/moodle.git
Pull Main Branch:
~~MDL-64348~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...ryanwyllie:MDL-64348-master
Testing Instructions:
Hide

These changes will largely be covered by behat tests however we can confirm with some manual tests.

Create a couple of courses and enrol a few users in those courses

Log in as a user

View the dashboard

CONFIRM everything loads correctly

In a separate window, purge the Moodle caches

Reload the dashboard for the user

CONFIRM that everything loads correctly again (this will be requesting everything from the server again because the caches are empty)

Open the message drawer

Find another user and send them a few messages

CONFIRM it all loads and renders correctly

Purge the Moodle caches again from another window

Reload the page for the user and open the message drawer again

View the conversation

CONFIRM it all loads correctly
Show
These changes will largely be covered by behat tests however we can confirm with some manual tests. Create a couple of courses and enrol a few users in those courses Log in as a user View the dashboard CONFIRM everything loads correctly In a separate window, purge the Moodle caches Reload the dashboard for the user CONFIRM that everything loads correctly again (this will be requesting everything from the server again because the caches are empty) Open the message drawer Find another user and send them a few messages CONFIRM it all loads and renders correctly Purge the Moodle caches again from another window Reload the page for the user and open the message drawer again View the conversation CONFIRM it all loads correctly

Description

At the moment when we fetch templates via ajax we do so one at a time because the client parses each template individually as it receives it and then fetches each other template it needs as it finds out that it needs them during the parsing.

This can result in 10s of network requests to the server to render a single template that has lots of other embedded templates.

However often times we know that the single template can't be rendered without all of the subsequent templates so rather than send back a single template the server should pre-parse the template being requested to find all of the other templates that are required to render this one and should send those back to the client in the same request.

This would allow the client to get all of the templates it needs in a single network request rather than in multiple subsequent requests.

This would be a massive win both in terms of number of requests and speed of template rendering for the client.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-64348.jpg
19 kB
09/Jan/19 1:10 PM

Issue Links

caused a regression

MDL-63244 Some of the calendar language translations are ignored

Closed

MDL-64757 Some Dashboard elements are following browser language, not page language

Closed

has been marked as being related by

MDL-65107 Conside it JS lang string caching should be by lang or no

Open

Activity

People

Assignee:: Ryan Wyllie

Reporter:: Ryan Wyllie

Peer reviewer:: Andrew Lyons

Integrator:: Jake Dallimore

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, Damyon Wiese, Eloy Lafuente (stronk7), Jake Dallimore, Ryan Wyllie

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 07/Dec/18 11:41 AM

Updated:: 01/Aug/19 6:35 AM

Resolved:: 11/Jan/19 1:43 AM

Fix Release Date:: 20/May/19

Time Tracking

Estimated:

Remaining:

Logged:

20m