Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66477

Create settings side drawer for new discussion view

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      * Please test on both boost and classic theme.
      Setup
      1. Enable Portfolio (use File download)
      2. Set up a forum f1 with an optional subscription with a discussion d1
      3. Set up another forum f2 with forced subscription and a discussion d2
      4. Set up another forum f3 without subscription and a discussion d3.
      5. Install the Hebrew language pack.
      Settings drawer
      1. Go to any discussion.
      2. Switch the display mode of the discussion to "modern"
      3. Confirm that you see the discussion settings trigger (cog icon) on the top right hand of the discussion page.
      4. Click on the settings drawer trigger.
      5. Confirm that the discussion settings drawer expands.
      6. Click on it again (you might wanna make sure that the browser width is wide enough to keep the trigger visible)
      7. Confirm that the settings drawer closes.
      8. Click on the trigger again.
      9. This time, click on the right arrow beside the Settings header in the drawer.
      10. Confirm that the drawer closes.
      11. Switch to the Hebrew language
      12. Confirm that the settings drawer trigger is on the top left-hand corner of the discussion page.
      13. Click on the settings drawer trigger.
      14. Confirm that the drawer slides from the left side of the page.
      15. Click on the left icon beside the Settings header.
      16. Confirm that the drawer closes.
      Forum with optional subscription
      1. Go to d1
      2. Open the settings drawer
      3. Confirm that you see the subscription toggle.
      4. Click on the subscription toggle.
      5. Confirm that you are being subscribed/unsubscribed from the discussion.
      Forum with forced/without subscriptions
      1. Go to d2 and d3.
      2. Confirm that when you expand the settings drawer the subscription toggle is not being shown.
      Regression check
      1. Switch the forum display mode back to one of the older modes (nested will work)
      2. Confirm that all of the actions in the settings menu still work (starring, pinning, locking, subscribing)
      Other functionalities - Teacher
      1. Log in as a teacher in the course.
      2. Go to any discussion
      3. Open the settings drawer
      4. Confirm that the following functionalities work as well:
        • Starring/unstarring discussions
        • Pinning/unpinning discussions
        • Locking/unlocking discussions
        • Switching display modes
        • Moving discussion to another forum
        • Exporting discussion to your portfolio
      Other functionalities - Student
      1. Log in as a student in the course.
      2. Go to any discussion
      3. Open the settings drawer
      4. Confirm that the following actions are shown
        • Starring/unstarring discussion
        • Switching viewing modes
        • Exporting discussion to your portfolio.
      5. Confirm that the following functionalities are not available:
        • Pinning/unpinning discussions
        • Locking/unlocking discussions
        • Moving discussion to another forum

      (Changes in messaging will be tested by Behat)

      Show
      * Please test on both boost and classic theme. Setup Enable Portfolio (use File download ) Set up a forum f1 with an optional subscription with a discussion d1 Set up another forum f2 with forced subscription and a discussion d2 Set up another forum f3 without subscription and a discussion d3. Install the Hebrew language pack. Settings drawer Go to any discussion. Switch the display mode of the discussion to "modern" Confirm that you see the discussion settings trigger (cog icon) on the top right hand of the discussion page. Click on the settings drawer trigger. Confirm that the discussion settings drawer expands. Click on it again (you might wanna make sure that the browser width is wide enough to keep the trigger visible) Confirm that the settings drawer closes. Click on the trigger again. This time, click on the right arrow beside the Settings header in the drawer. Confirm that the drawer closes. Switch to the Hebrew language Confirm that the settings drawer trigger is on the top left-hand corner of the discussion page. Click on the settings drawer trigger. Confirm that the drawer slides from the left side of the page. Click on the left icon beside the Settings header. Confirm that the drawer closes. Forum with optional subscription Go to d1 Open the settings drawer Confirm that you see the subscription toggle. Click on the subscription toggle. Confirm that you are being subscribed/unsubscribed from the discussion. Forum with forced/without subscriptions Go to d2 and d3. Confirm that when you expand the settings drawer the subscription toggle is not being shown. Regression check Switch the forum display mode back to one of the older modes (nested will work) Confirm that all of the actions in the settings menu still work (starring, pinning, locking, subscribing) Other functionalities - Teacher Log in as a teacher in the course. Go to any discussion Open the settings drawer Confirm that the following functionalities work as well: Starring/unstarring discussions Pinning/unpinning discussions Locking/unlocking discussions Switching display modes Moving discussion to another forum Exporting discussion to your portfolio Other functionalities - Student Log in as a student in the course. Go to any discussion Open the settings drawer Confirm that the following actions are shown Starring/unstarring discussion Switching viewing modes Exporting discussion to your portfolio. Confirm that the following functionalities are not available: Pinning/unpinning discussions Locking/unlocking discussions Moving discussion to another forum (Changes in messaging will be tested by Behat)
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-66477-master
    • Story Points:
      1
    • Sprint:
      Sprint 5 - Sander's special, Sprint 6 - Looney Tunes, Sprint 7 - Race to the freeze

      Description

      Create a settings side drawer for the new forum view that contains all of the discussion header settings.

      The settings panel can contain a few sections such as:

      • General with toggles for
        • subscription
        • star
        • pin
        • locked
      • View which shows the view selector
      • Move which shows the move selector
      • Export to portfolio button (if enabled)

      The prototype here shows the side panel without any content:
      https://projects.invisionapp.com/d/main/?origin=v7#/console/18367584/381579786/preview
      (old prototype)

      See the "settings" part of the messaging drawer for an example of how it might look.

      Implementation details

      • It would be good to create generic side drawer code/component which can be re-used between this and the messaging drawer

      Acceptance criteria

      • Discussion heading options are all moved into a settings side drawer

        Attachments

        1. Forum with forced without subscriptions_Boost.png
          Forum with forced without subscriptions_Boost.png
          58 kB
        2. Forum with optional and Forum with forced without subscription_Classic.png
          Forum with optional and Forum with forced without subscription_Classic.png
          152 kB
        3. Forum with optional subscription_Boost.png
          Forum with optional subscription_Boost.png
          77 kB
        4. Other functionalities  Student_Classic.PNG
          Other functionalities Student_Classic.PNG
          32 kB
        5. Other functionalities - Students_Boost.PNG
          Other functionalities - Students_Boost.PNG
          28 kB
        6. Other functionalities - Teacher _Boost.png
          Other functionalities - Teacher _Boost.png
          253 kB
        7. Other functionalities  Teacher_Classic.png
          Other functionalities Teacher_Classic.png
          372 kB
        8. Regression check_ Boost.png
          Regression check_ Boost.png
          109 kB
        9. Regression check_Classic.png
          Regression check_Classic.png
          146 kB
        10. Screenshot_1.png
          Screenshot_1.png
          135 kB
        11. Screenshot_2.png
          Screenshot_2.png
          140 kB
        12. Screenshot_3.png
          Screenshot_3.png
          127 kB
        13. Screenshot_4.png
          Screenshot_4.png
          200 kB
        14. Screenshot_5.png
          Screenshot_5.png
          140 kB
        15. Screenshot_6.png
          Screenshot_6.png
          73 kB
        16. Setting Drawer_Classic.png
          Setting Drawer_Classic.png
          323 kB
        17. Settings drawer_Boost.png
          Settings drawer_Boost.png
          196 kB

          Issue Links

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              ryanwyllie Ryan Wyllie
              Peer reviewer:
              Ryan Wyllie
              Integrator:
              Adrian Greeve
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 week, 1 day, 7 hours
                  1w 1d 7h