Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66816

Question bank: replace the row of edit icons with an Edit menu

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This change affects the list of questions in the question bank, and the actions you can perform on them.

      It does not change what any of the actions do* or how they are implemented, it only changes how they are triggered. What used to be icon links are now menu entries.

      The Behat coverage here is good, so the manual testing is just an extra confirmation.

      1. Find a course containing questions in the question bank.
      2. Work down all the options in the edit menu for one question, and verify that they all work.
      3. (Note, the export as XML option is new, but that functionality used to be on the question preview page.)

      When I say "it does not change what any of the actions do", there is one subtle difference. In the past the Preview action opened in a pop-up window. Now it opens in a new tab. I am claiming that in 2019, this is an improvement.

      Show
      This change affects the list of questions in the question bank, and the actions you can perform on them. It does not change what any of the actions do* or how they are implemented, it only changes how they are triggered. What used to be icon links are now menu entries. The Behat coverage here is good, so the manual testing is just an extra confirmation. Find a course containing questions in the question bank. Work down all the options in the edit menu for one question, and verify that they all work. (Note, the export as XML option is new, but that functionality used to be on the question preview page.) When I say "it does not change what any of the actions do", there is one subtle difference. In the past the Preview action opened in a pop-up window. Now it opens in a new tab. I am claiming that in 2019, this is an improvement.
    • Workaround:
      Hide

      The behat coverage for this is good. If you want to test manually:

      1. Go to any course with questions in the question bank.
      2. Note the Edit menu for each quesion.
      3. Test each action in the menu in turn.
      Show
      The behat coverage for this is good. If you want to test manually: Go to any course with questions in the question bank. Note the Edit menu for each quesion. Test each action in the menu in turn.
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull Master Branch:

      Description

      Over time, in Moodle, the user-interface convention has been to replace rows of icons with an Edit drop-down menu. It would make sense to do the same thing in the qustion bank. That way, there could be a word next to each icon, and it would make the UI more extensible.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                timhunt Tim Hunt
                Reporter:
                timhunt Tim Hunt
                Peer reviewer:
                Mahmoud Kassaei
                Integrator:
                Jake Dallimore
                Participants:
                Component watchers:
                Tim Hunt, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze, Barbara Ramiro, Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated: